You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/09 21:16:58 UTC

[jira] [Commented] (MINIFI-135) Remove "Input Port" and "Output Port" from default config root level

    [ https://issues.apache.org/jira/browse/MINIFI-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15652056#comment-15652056 ] 

ASF GitHub Bot commented on MINIFI-135:
---------------------------------------

GitHub user JPercivall opened a pull request:

    https://github.com/apache/nifi-minifi/pull/54

    MINIFI-135 Removing 'Input Ports' and 'Output Ports' from the root le…

    …vel of the default config
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JPercivall/nifi-minifi MINIFI-135

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #54
    
----
commit 52bcec8d305c04b4002d32b191936a13a87fe879
Author: Joseph Percivall <jp...@apache.org>
Date:   2016-11-09T21:14:18Z

    MINIFI-135 Removing 'Input Ports' and 'Output Ports' from the root level of the default config

----


> Remove "Input Port" and "Output Port" from default config root level
> --------------------------------------------------------------------
>
>                 Key: MINIFI-135
>                 URL: https://issues.apache.org/jira/browse/MINIFI-135
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>            Reporter: Joseph Percivall
>            Assignee: Joseph Percivall
>            Priority: Trivial
>             Fix For: 0.1.0
>
>
> Currently Input/Output ports are supported as components but only internally as I/O to Process Groups. They are not supported on the root level as external facing ports.
> Currently the default config.yml is pre-populated with an empty list of "Input Ports" and "Output Ports" in the root level. Those should be removed so that it is not confusing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)