You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2016/03/12 23:57:18 UTC
Deprecate HtmlDocumentValidator ?
Hi,
I want to
propose org.apache.wicket.protocol.http.documentvalidation.HtmlDocumentValidator
for deprecation in Wicket 8.x and removal in 9.x.
I'm 100% sure no one uses this way of testing.
Tests based on HtmlDocumentValidator fail as soon as a single character is
changed in the page markup.
They are also very verbose to write:
https://github.com/apache/wicket/blob/859b0313469215dd230d69f64f475f7b86be7360/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableTest.java#L62
There are 4 tests in wicket-core that uses it.
Will be easy to replace with TagTester or WicketTestCase#executeTest()
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
Re: Deprecate HtmlDocumentValidator ?
Posted by Martin Grigorov <mg...@apache.org>.
https://issues.apache.org/jira/browse/WICKET-6119
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Sun, Mar 13, 2016 at 12:08 PM, Martijn Dashorst <
martijn.dashorst@gmail.com> wrote:
> Sounds like a plan!
>
> Martijn
>
> On Sun, Mar 13, 2016 at 9:21 AM, Sven Meier <sv...@meiers.net> wrote:
> > +1
> >
> > Sven
> >
> >
> > On 12.03.2016 23:57, Martin Grigorov wrote:
> >>
> >> Hi,
> >>
> >> I want to
> >> propose
> >> org.apache.wicket.protocol.http.documentvalidation.HtmlDocumentValidator
> >> for deprecation in Wicket 8.x and removal in 9.x.
> >>
> >> I'm 100% sure no one uses this way of testing.
> >> Tests based on HtmlDocumentValidator fail as soon as a single character
> is
> >> changed in the page markup.
> >> They are also very verbose to write:
> >>
> >>
> https://github.com/apache/wicket/blob/859b0313469215dd230d69f64f475f7b86be7360/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableTest.java#L62
> >>
> >> There are 4 tests in wicket-core that uses it.
> >> Will be easy to replace with TagTester or WicketTestCase#executeTest()
> >>
> >>
> >> Martin Grigorov
> >> Wicket Training and Consulting
> >> https://twitter.com/mtgrigorov
> >>
> >
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
>
Re: Deprecate HtmlDocumentValidator ?
Posted by Martijn Dashorst <ma...@gmail.com>.
Sounds like a plan!
Martijn
On Sun, Mar 13, 2016 at 9:21 AM, Sven Meier <sv...@meiers.net> wrote:
> +1
>
> Sven
>
>
> On 12.03.2016 23:57, Martin Grigorov wrote:
>>
>> Hi,
>>
>> I want to
>> propose
>> org.apache.wicket.protocol.http.documentvalidation.HtmlDocumentValidator
>> for deprecation in Wicket 8.x and removal in 9.x.
>>
>> I'm 100% sure no one uses this way of testing.
>> Tests based on HtmlDocumentValidator fail as soon as a single character is
>> changed in the page markup.
>> They are also very verbose to write:
>>
>> https://github.com/apache/wicket/blob/859b0313469215dd230d69f64f475f7b86be7360/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableTest.java#L62
>>
>> There are 4 tests in wicket-core that uses it.
>> Will be easy to replace with TagTester or WicketTestCase#executeTest()
>>
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: Deprecate HtmlDocumentValidator ?
Posted by Sven Meier <sv...@meiers.net>.
+1
Sven
On 12.03.2016 23:57, Martin Grigorov wrote:
> Hi,
>
> I want to
> propose org.apache.wicket.protocol.http.documentvalidation.HtmlDocumentValidator
> for deprecation in Wicket 8.x and removal in 9.x.
>
> I'm 100% sure no one uses this way of testing.
> Tests based on HtmlDocumentValidator fail as soon as a single character is
> changed in the page markup.
> They are also very verbose to write:
> https://github.com/apache/wicket/blob/859b0313469215dd230d69f64f475f7b86be7360/wicket-core/src/test/java/org/apache/wicket/markup/html/list/PagedTableTest.java#L62
>
> There are 4 tests in wicket-core that uses it.
> Will be easy to replace with TagTester or WicketTestCase#executeTest()
>
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>