You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/11/01 00:00:42 UTC
[GitHub] [accumulo] keith-turner opened a new pull request, #3059: fixes #3045 remove stale compactions from coordinator
keith-turner opened a new pull request, #3059:
URL: https://github.com/apache/accumulo/pull/3059
I added a unit test and I ran all ITs that matched the pattern `*Compaction*IT` but have not tested the scenario in #3045 with these changes. The unit test shows it working in isolation, but not end to end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #3059: fixes #3045 remove stale compactions from coordinator
Posted by GitBox <gi...@apache.org>.
keith-turner commented on PR #3059:
URL: https://github.com/apache/accumulo/pull/3059#issuecomment-1298595882
> Looks good, but I wonder if we should put the cleanup in a background thread instead of on the request thread that the Monitor uses to get the data. I'm not sure that this is super-important, as I think the orphaned RUNNING entries happen in a small number of cases. But, if the Monitor is down or never used by the user, then no cleanup will happen.
When I first started looking into this I was considering adding this code to the DeadCompactionDetector because it already scans the metadata table and runs periodically in the background. I decided against this because I thought it may make the code harder to understand and would force these two task to run at the same cadence. I think I will take another look at making it run in the background as a task or as part of the dead compaction detector.
> Test seems to fail on JDK 17. Not sure what's going on with that.
I saw that, going to look into it. Seemed to be failing to initialize the class, wonder if thats because I called System.nanoTime to initialize an instance var and maybe JDK 17 does not like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman closed pull request #3059: fixes #3045 remove stale compactions from coordinator
Posted by GitBox <gi...@apache.org>.
EdColeman closed pull request #3059: fixes #3045 remove stale compactions from coordinator
URL: https://github.com/apache/accumulo/pull/3059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #3059: fixes #3045 remove stale compactions from coordinator
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #3059:
URL: https://github.com/apache/accumulo/pull/3059#issuecomment-1298567159
Test seems to fail on JDK 17. Not sure what's going on with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner merged pull request #3059: fixes #3045 remove stale compactions from coordinator
Posted by GitBox <gi...@apache.org>.
keith-turner merged PR #3059:
URL: https://github.com/apache/accumulo/pull/3059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #3059: fixes #3045 remove stale compactions from coordinator
Posted by GitBox <gi...@apache.org>.
keith-turner commented on PR #3059:
URL: https://github.com/apache/accumulo/pull/3059#issuecomment-1300612871
> But, if the Monitor is down or never used by the user, then no cleanup will happen.
@dlmarion I modified the code to run periodically in the background. This could avoid an OOME in a long running coordinator process for that case you mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] keith-turner commented on pull request #3059: fixes #3045 remove stale compactions from coordinator
Posted by GitBox <gi...@apache.org>.
keith-turner commented on PR #3059:
URL: https://github.com/apache/accumulo/pull/3059#issuecomment-1298873889
> Test seems to fail on JDK 17. Not sure what's going on with that.
I was able to reproduce this locally and fix it locally in commit [7249313](https://github.com/apache/accumulo/pull/3059/commits/7249313ceecc4c6815654336bb6a7ec68630b838). Was a problem with powermock, reflection, and java modules. Needed to add java.time which contained the Duration class that powermock was trying to modify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org