You are viewing a plain text version of this content. The canonical link for it is here.
Posted to devnull@infra.apache.org by "chenzefeng09 (GitHub)" <gi...@apache.org> on 2018/08/22 02:35:55 UTC
[GitHub] [incubator-weex] chenzefeng09 opened pull request #1460:
[android] fix 'onFocus invoked twice
when <input> label has both '@focus' & '@blur' method, both methods will be invoked twice when trigger focus/blur event
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] YorkShen commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "YorkShen (GitHub)" <gi...@apache.org>.
Please rebase your commit, there is a conflict. @chenzefeng09
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
1 failure: Failed to run ass...
0 warning:
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Failed to run assembleDebug task for android.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>android build verification finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
1 failure: Failed to run ass...
0 warning:
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Failed to run assembleDebug task for android.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>android build verification finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] YorkShen closed pull request #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "YorkShen (GitHub)" <gi...@apache.org>.
[ pull request closed by YorkShen ]
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
1 failure: Failed to run ass...
0 warning:
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Failed to run assembleDebug task for android.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>android build verification finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] YorkShen commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "YorkShen (GitHub)" <gi...@apache.org>.
@gubaojian Need your approval, thanks
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] chenzefeng09 commented on pull request
#1460: [WEEX-581][android] fix 'onFocus invoked twice
Posted by "chenzefeng09 (GitHub)" <gi...@apache.org>.
done
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
1 failure: Failed to run ass...
0 warning:
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Fails</th>
</tr>
</thead>
<tbody><tr>
<td>:no_entry_sign:</td>
<td>Failed to run assembleDebug task for android.</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>android build verification finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] chenzefeng09 commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "chenzefeng09 (GitHub)" <gi...@apache.org>.
conflict resolved @YorkShen @gubaojian
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] YorkShen commented on pull request #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "YorkShen (GitHub)" <gi...@apache.org>.
Sorry for the delay.
Make `mHasAddFocusListener` to private, thanks.
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] weex-bot commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "weex-bot (GitHub)" <gi...@apache.org>.
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org
[GitHub] [incubator-weex] chenzefeng09 commented on issue #1460:
[WEEX-581][android] fix 'onFocus invoked twice
Posted by "chenzefeng09 (GitHub)" <gi...@apache.org>.
conflict resolved @YorkShen
[ Full content available at: https://github.com/apache/incubator-weex/pull/1460 ]
This message was relayed via gitbox.apache.org for devnull@infra.apache.org