You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/02 17:43:45 UTC
[jira] [Commented] (BEAM-818) Remove Pipeline.getPipelineOptions
[ https://issues.apache.org/jira/browse/BEAM-818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892667#comment-15892667 ]
ASF GitHub Bot commented on BEAM-818:
-------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2142
[BEAM-818] Deprecate Pipeline.getOptions
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
Configuration should be explicit pre-execution, and after the call to
Run a PipelineRunner controls the PipelineOptions of the executions.
Runtime access to options is unaffected by this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam deprecate_pipeline_getOptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2142
----
----
> Remove Pipeline.getPipelineOptions
> ----------------------------------
>
> Key: BEAM-818
> URL: https://issues.apache.org/jira/browse/BEAM-818
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
> Labels: backward-incompatible
>
> This stops transforms from changing their operation based on construction-time options, and instead requires that configuration to be explicit, or to obtain the configuration at runtime.
> https://docs.google.com/document/d/1Wr05cYdqnCfrLLqSk--XmGMGgDwwNwWZaFbxLKvPqEQ/edit#
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)