You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2011/01/02 15:06:46 UTC

[jira] Resolved: (WICKET-3299) Please un-deprecate WebApplication.mount

     [ https://issues.apache.org/jira/browse/WICKET-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-3299.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.5-M4

Done with r1054407.
Additionally #mountPackage() is added to be consistent with 1.4. 

> Please un-deprecate WebApplication.mount
> ----------------------------------------
>
>                 Key: WICKET-3299
>                 URL: https://issues.apache.org/jira/browse/WICKET-3299
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-M3
>            Reporter: Willis Blackburn
>            Assignee: Martin Grigorov
>             Fix For: 1.5-M4
>
>
> WebApplication.mount is deprecated with the comment:
> 	 * @deprecated this is the same as {@code getRootRequestMapperAsCompound().add(mapper)}
> Sure it's the same but mount(mapper) is much clearer.  And WebApplication.mountPage is the same as:
> 		getRootRequestMapperAsCompound().add(new MountedMapper(path, pageClass));
> but it's not deprecated.  Wicket is full of shortcut functions (for example Component.setResponsePage is the same as getRequestCycle().setResponsePage(page));  why get rid of this one?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.