You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/10 14:42:09 UTC
[GitHub] [incubator-nuttx] anpaza opened a new pull request #527: STM32H753II
anpaza opened a new pull request #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527
Basic support for the STM32H753II chip.
It is pretty the same as the STM32H743ZI chip, so it re-uses files from 743, just adding extra #ifdefs. The only difference between 753 and 743 is the addition of cryptographic peripherial.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #527:
STM32H753II
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597233802
> @xiaoxiang781216
>
> > The better approach is append your style patch to this PR and trigger the precheck again:
> > https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
>
> Yes. That it the right approach, and I will do it that way when I have time.
>
> Did you add it to the work flow document?
The workflow document contain many options now, and it's hard for newbie to follow up. I would prefer that the main body of workflow document just describe the best practice the most contributor use daliy, for example:
1.One method to get source code
2.One method to send PR
3.One method to rework the PR after review
The reader just need follow the sequence step by step, no any if/else at all.
And then the document could list other alternatives or advance usage like this in the note section.
Also it's better to list the contributor workflow first, then commit workflow, last the advance tips.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #527: STM32H753II
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597209034
@xiaoxiang781216
>The better approach is append your style patch to this PR and trigger the precheck again:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
Yes. That it the right approach, and I will do it that way when I have time.
Did you add it to the work flow document?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #527: STM32H753II
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597275720
Many people have contributed and reviewed that workflow. It would be extremely bad style to discard that work. I would have to be opposed to this.
The document must be fully inclusive and represent all people. If you want a fully compkatible, short version, that would have to be in addition to the work of others and not a replacement for the work others.
Let's not "steam roller" ovee the community
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #527: STM32H753II
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597263918
> The reader just need follow the sequence step by step, no any if/else at all.
+1
@xiaoxiang781216 good point - maybe it should be 3 pages.
1 Simple highlevel contributing
2 Contributing workflow
2 Commiter's workflow
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #527: STM32H753II
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597135580
@xiaoxiang781216 - Oh so that was your argument.
I will do a separate PR and fix all the style issues once the tools can report the real ones. This contributor has suffered from the tooling issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 merged pull request #527: STM32H753II
Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #527:
STM32H753II
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597146448
> @xiaoxiang781216 - Oh so that was your argument.
>
Yes, I already express my opinion in email thread. We should try our best to follow the rule, right?
> I will do a separate PR and fix all the style issues once the tools can report the real ones. This contributor has suffered from the tooling issues.
But can you ensure the change pass the build? Yes, this patch is small, how about a little big change?
The better approach is append your style patch to this PR and trigger the precheck again:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #527:
STM32H753II
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597233802
> @xiaoxiang781216
>
> > The better approach is append your style patch to this PR and trigger the precheck again:
> > https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
>
> Yes. That it the right approach, and I will do it that way when I have time.
>
> Did you add it to the work flow document?
The workflow document contain many options now, and it's hard for newbie to follow up. I would prefer that the main body of workflow document just describe the best practice the most contributor use daliy, for example:
1.One method to get source code
2.One method to send PR
3.One method to rework the PR after review
The reader just need follow the sequence step by step, no any if/else at all.
And then the document could list other alternatives or advance usage like this in the note section.
Also it's better to list the contributor workflow first, then additional committer workflow, last the advance tips.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #527:
STM32H753II
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597233802
> @xiaoxiang781216
>
> > The better approach is append your style patch to this PR and trigger the precheck again:
> > https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
>
> Yes. That it the right approach, and I will do it that way when I have time.
>
> Did you add it to the work flow document?
The workflow document contain many options now, and it's hard for newbie to follow up. I would prefer that the main body of workflow document just describe the best practice the most contributor use daliy, for example:
1.One method to get source code
2.One method to send PR
3.One method to rework the PR after review
The reader just need follow the sequence step by step, no any if/else at all.
And then the document could list other alternatives or advance usage like this in the note section.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #527:
STM32H753II
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597146448
> @xiaoxiang781216 - Oh so that was your argument.
>
Yes, I already express my opinion in email thread. We should try our best to follow the rule, right?
> I will do a separate PR and fix all the style issues once the tools can report the real ones. This contributor has suffered from the tooling issues.
But can you ensure the change can pass the build? Yes, this patch is small, how about a little big change?
The better approach is append your style patch to this PR and trigger the precheck again:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/committing-changes-to-a-pull-request-branch-created-from-a-fork
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #527:
STM32H753II
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #527: STM32H753II
URL: https://github.com/apache/incubator-nuttx/pull/527#issuecomment-597131803
> The CI is just style. The value is in the change.
@davids5 , why you bypass the style check? Don't break the rule you vote +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services