You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "itxaiohanglover (via GitHub)" <gi...@apache.org> on 2026/07/05 16:25:36 UTC

[PR] [ISSUE #380] Fix message track showing NOT_CONSUME_YET for consumed messages [rocketmq]

itxaiohanglover opened a new pull request, #10595:
URL: https://github.com/apache/rocketmq/pull/10595

   ## What is the purpose of the change
   
   Fixes apache/rocketmq-dashboard#380
   
   In `DefaultMQAdminExtImpl.consumed()` and `consumedConcurrent()`, the consumer offset comparison used strict `>` instead of `>=`. When the consumer offset exactly matched the message's queue offset, the message was incorrectly reported as `NOT_CONSUME_YET` instead of `CONSUMED`.
   
   ## Brief changelog
   
   - Changed `>` to `>=` in `consumed()` method
   - Changed `>` to `>=` in `consumedConcurrent()` method
   - Added test `testConsumedWithEqualOffset` verifying the fix
   
   ## Verifying this change
   
   Added test case `testConsumedWithEqualOffset` that sets consumerOffset equal to the message's queueOffset and verifies `consumed()` returns true.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #380] Fix message track showing NOT_CONSUME_YET for consumed messages [rocketmq]

Posted by "itxaiohanglover (via GitHub)" <gi...@apache.org>.
itxaiohanglover commented on PR #10595:
URL: https://github.com/apache/rocketmq/pull/10595#issuecomment-4889350428

   Thank you for the review @yx9o. You're right — `consumerOffset` represents the next offset to consume, so the current `>` check is correct. A message at exactly `consumerOffset` hasn't been consumed yet.
   
   Closing this PR as the fix is incorrect. I'll re-investigate the root cause of the dashboard issue #380 to find the actual source of the false NOT_CONSUME_YET status.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #380] Fix message track showing NOT_CONSUME_YET for consumed messages [rocketmq]

Posted by "itxaiohanglover (via GitHub)" <gi...@apache.org>.
itxaiohanglover closed pull request #10595: [ISSUE #380] Fix message track showing NOT_CONSUME_YET for consumed messages
URL: https://github.com/apache/rocketmq/pull/10595


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org