[GitHub] nwangtw commented on a change in pull request #3161: create a symbolic link for kubernetes conf after loading docker image

[GitBox <gi...@apache.org>]

nwangtw commented on a change in pull request #3161: create a symbolic link for kubernetes conf after loading docker image
URL: https://github.com/apache/incubator-heron/pull/3161#discussion_r248890652
 
 

 ##########
 File path: heron/spi/src/java/org/apache/heron/spi/common/Key.java
 ##########
 @@ -187,6 +187,7 @@
   PYTHON_INSTANCE_BINARY("heron.binaries.python.instance", "${HERON_BIN}/heron-python-instance"),
   CPP_INSTANCE_BINARY   ("heron.binaries.cpp.instance",    "${HERON_BIN}/heron-cpp-instance"),
   DOWNLOADER_BINARY     ("heron.binaries.downloader",      "${HERON_BIN}/heron-downloader"),
+  DOWNLOADER_CONF_KUBERNETES ("heron.binaries.downloader-conf-kubernetes",  "${HERON_BIN}/heron-downloader-config-kubernetes"),
 
 Review comment:
   is it possible to avoid platform specific key and value and use a general config here? SPI is an interface for all platforms.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services