You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2021/04/07 10:39:22 UTC

[GitHub] [incubator-hop] sramazzina opened a new pull request #735: Various fixes and improvements

sramazzina opened a new pull request #735:
URL: https://github.com/apache/incubator-hop/pull/735


   HOP-2733 - Fixed hardcoded strings in ProjectDialog and ProjectsGuiPlugin
   HOP-2729 - Given capability to add an existing project to Hop
   HOP-2330
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hop] mattcasters commented on pull request #735: Various fixes and improvements

Posted by GitBox <gi...@apache.org>.
mattcasters commented on pull request #735:
URL: https://github.com/apache/incubator-hop/pull/735#issuecomment-817695622


   When I'm testing this and create a project in a folder where there already is a project-config.json file I get the following dialog:
   
   ![image](https://user-images.githubusercontent.com/1724620/114380737-b0447280-9b8a-11eb-8ac5-f5f615ce516d.png)
   
   This is incorrect.  The project does not exist yet.  It's the project configuration file which exists.  Can we re-word this to clarify?
   
   `An existing project configuration file was found in the specified folder. It will be used for this project.`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hop] mattcasters commented on a change in pull request #735: Various fixes and improvements

Posted by GitBox <gi...@apache.org>.
mattcasters commented on a change in pull request #735:
URL: https://github.com/apache/incubator-hop/pull/735#discussion_r608690783



##########
File path: plugins/misc/projects/src/main/java/org/apache/hop/projects/gui/ProjectsGuiPlugin.java
##########
@@ -239,7 +244,20 @@ public void addNewProject() {
 
         // Save the project-config.json file as well in the project itself
         //
-        project.saveToFile();
+        File configFile = new File(projectConfig.getConfigFilename());
+
+        if (!configFile.exists()) {

Review comment:
       This never works for relative paths. We need to check a path relative to the project location. 
   We can use:  `projectConfig.getActualProjectConfigFilename(variables)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hop] sramazzina commented on pull request #735: Various fixes and improvements

Posted by GitBox <gi...@apache.org>.
sramazzina commented on pull request #735:
URL: https://github.com/apache/incubator-hop/pull/735#issuecomment-817874868


   My bad, I missed your last comment :-(. I'm going to push the changes with the re-worded message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hop] sramazzina commented on a change in pull request #735: Various fixes and improvements

Posted by GitBox <gi...@apache.org>.
sramazzina commented on a change in pull request #735:
URL: https://github.com/apache/incubator-hop/pull/735#discussion_r608700791



##########
File path: plugins/misc/projects/src/main/java/org/apache/hop/projects/gui/ProjectsGuiPlugin.java
##########
@@ -239,7 +244,20 @@ public void addNewProject() {
 
         // Save the project-config.json file as well in the project itself
         //
-        project.saveToFile();
+        File configFile = new File(projectConfig.getConfigFilename());
+
+        if (!configFile.exists()) {

Review comment:
       I willl fix it. Thanks for the suggestion




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-hop] mattcasters merged pull request #735: Various fixes and improvements

Posted by GitBox <gi...@apache.org>.
mattcasters merged pull request #735:
URL: https://github.com/apache/incubator-hop/pull/735


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org