You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/16 10:53:20 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #14082: GH-32901: [C++][Python] Add Flight SQL ADBC driver

pitrou commented on code in PR #14082:
URL: https://github.com/apache/arrow/pull/14082#discussion_r1071087928


##########
cpp/src/arrow/flight/sql/CMakeLists.txt:
##########
@@ -124,8 +126,15 @@ if(ARROW_BUILD_TESTS OR ARROW_BUILD_EXAMPLES)
                  STATIC_LINK_LIBS
                  ${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}
                  ${ARROW_FLIGHT_SQL_TEST_LIBS}
+                 nanoarrow
+                 AdbcValidation::adbc_validation
+                 # Needs to come twice since the validation library
+                 # also uses ADBC symbols, which get provided by
+                 # libarrow_flight_sql here.
+                 ${ARROW_FLIGHT_SQL_TEST_LINK_LIBS}

Review Comment:
   Wouldn't it be enough to instead move `nanoarrow` and `AdbcValidation::adbc_validation` before the Flight SQL link libs? Or am I misunderstanding something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org