You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/23 05:34:03 UTC
[GitHub] [spark] MaxGekk commented on a diff in pull request #25004: [SPARK-28205][SQL] useV1SourceList configuration should be for all data sources
MaxGekk commented on code in PR #25004:
URL: https://github.com/apache/spark/pull/25004#discussion_r1030034252
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/v2/FileDataSourceV2FallBackSuite.scala:
##########
@@ -170,4 +174,46 @@ class FileDataSourceV2FallBackSuite extends QueryTest with SharedSQLContext {
}
}
}
+
+ test("Fallback Parquet V2 to V1") {
Review Comment:
This test is flaky, it seems. Failed in my PR w/ unrelated changes:
```
sbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: ArrayBuffer(("collect", Relation [id#725095L] parquet
), ("command", InsertIntoHadoopFsRelationCommand file:/home/runner/work/spark/spark/target/tmp/spark-0d0623b6-2cdd-4ed0-bd86-0116ec152a01, false, Parquet, [path=/home/runner/work/spark/spark/target/tmp/spark-0d0623b6-2cdd-4ed0-bd86-0116ec152a01], ErrorIfExists, [id]
+- Range (0, 10, step=1, splits=Some(2))
)) had length 2 instead of expected length 1
at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
at org.apache.spark.sql.connector.FileDataSourceV2FallBackSuite.$anonfun$new$22(FileDataSourceV2FallBackSuite.scala:179)
at org.apache.spark.sql.connector.FileDataSourceV2FallBackSuite.$anonfun$new$22$adapted(FileDataSourceV2FallBackSuite.scala:175)
```
see https://github.com/MaxGekk/spark/runs/9650795751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org