You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by asanjar <gi...@git.apache.org> on 2016/11/21 18:20:25 UTC
[GitHub] zeppelin pull request #1666: [ZEPPELIN-1689] enable Power architecture
GitHub user asanjar opened a pull request:
https://github.com/apache/zeppelin/pull/1666
[ZEPPELIN-1689] enable Power architecture
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
this patch is platform independent and should not effect Intel architecture. We are simply upgrading the version of fronend-maven-plugin, nodejs, phantomjs-launcher to versions that are supported by Power architecture as well.
### What type of PR is it?
[ Feature ]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1689
### How should this be tested?
should test on x86 for any regression, highly unlikely.
OpenPOWER foundation team has already verified the patch on Power as part of Apache Bigtop project.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asanjar/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1666.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1666
----
commit 2f928457ac2a67e280db4163b7aa527c41da2c38
Author: amir sanjar <af...@gmail.com>
Date: 2016-11-21T18:12:47Z
ZEPPELIN-1689: enable Power architecture
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1666: [ZEPPELIN-1689] enable Power architecture
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1666
\U0001f44d Looks good to me, merging if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1666: [ZEPPELIN-1689] enable Power architecture
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1666
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1666: [ZEPPELIN-1689] enable Power architecture
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1666
I think we can merge this first and then rebase #1659 easily :)
This PR looks good to me and is what we want :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1666: [ZEPPELIN-1689] enable Power architecture
Posted by asanjar <gi...@git.apache.org>.
Github user asanjar commented on the issue:
https://github.com/apache/zeppelin/pull/1666
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1666: [ZEPPELIN-1689] enable Power architecture
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1666
Indeed, if you could check #1659 - AFAIK it does all the same, only the node version is different there.
How about we merge this guy as it does not bring major changes and then rebase #1659 on it and see if we want to keep Node 6x there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1666: [ZEPPELIN-1689] enable Power architecture
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1666
Hi, @asanjar
Actually, we are talking about upgrading node, npm and karma related versions in https://github.com/apache/zeppelin/pull/1659
Could you check it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---