You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/13 11:27:21 UTC
[GitHub] [cloudstack] slavkap opened a new pull request #5023: Fix in Marvin - migrate_vm_with_volume
slavkap opened a new pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023
### Description
Cannot migrate VM to another storage, because 'migrateto' argument is overridden.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### How Has This Been Tested?
tested with Marvin nose tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842336986
Did a git grep and found:
```
test/integration/component/maint/testpath_disablestoragepool.py: self.virtual_machine_1.migrate_vm_with_volume(
test/integration/component/maint/testpath_disablestoragepool.py: self.virtual_machine_1.migrate_vm_with_volume(
test/integration/component/maint/testpath_vMotion_vmware.py: vm.migrate_vm_with_volume(
test/integration/component/test_storage_motion.py: def test_01_migrate_vm_with_volume(self):
test/integration/plugins/solidfire/TestVMMigrationWithStorage.py: virtual_machine.migrate_vm_with_volume(self.apiClient, dest_host.id)
test/integration/plugins/solidfire/TestVMMigrationWithStorage.py: virtual_machine.migrate_vm_with_volume(self.apiClient, dest_host.id)
test/integration/plugins/solidfire/TestVMMigrationWithStorage.py: virtual_machine.migrate_vm_with_volume(self.apiClient, dest_host.id)
test/integration/testpaths/testpath_storage_migration.py: vm.migrate_vm_with_volume(
tools/marvin/marvin/lib/base.py: def migrate_vm_with_volume(self, apiclient, hostid=None, migrateto=None):
```
The method is not used by tests that are run by travis or smoketests. I'll merge this based on code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842157604
@slavkap I've force-pushed rebasing your change to 4.15. Sorry if I shouldn't.
cc @rhtyd
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-841400972
Thanks @slavkap can you check and change the base branch of the PR to 4.15 - if it's applicable for 4.15 branch as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842138636
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842139222
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842138636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842183578
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842157098
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 43
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842139222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842153652
@rhtyd, It works on 4.15. I thought that there would be a problem if I change the base branch from here. That's why I've reverted it again to base
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842172722
Thanks, @shwstppr, it's ok for me! And thank you both for your time and review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
slavkap commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842153652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842336986
Did a git grep and found:
```
test/integration/component/maint/testpath_disablestoragepool.py: self.virtual_machine_1.migrate_vm_with_volume(
test/integration/component/maint/testpath_disablestoragepool.py: self.virtual_machine_1.migrate_vm_with_volume(
test/integration/component/maint/testpath_vMotion_vmware.py: vm.migrate_vm_with_volume(
test/integration/component/test_storage_motion.py: def test_01_migrate_vm_with_volume(self):
test/integration/plugins/solidfire/TestVMMigrationWithStorage.py: virtual_machine.migrate_vm_with_volume(self.apiClient, dest_host.id)
test/integration/plugins/solidfire/TestVMMigrationWithStorage.py: virtual_machine.migrate_vm_with_volume(self.apiClient, dest_host.id)
test/integration/plugins/solidfire/TestVMMigrationWithStorage.py: virtual_machine.migrate_vm_with_volume(self.apiClient, dest_host.id)
test/integration/testpaths/testpath_storage_migration.py: vm.migrate_vm_with_volume(
tools/marvin/marvin/lib/base.py: def migrate_vm_with_volume(self, apiclient, hostid=None, migrateto=None):
```
The method is not used by tests that are run by travis or smoketests. I'll merge this based on code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5023: Fix in Marvin - migrate_vm_with_volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5023:
URL: https://github.com/apache/cloudstack/pull/5023#issuecomment-842157888
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org