You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by jd...@apache.org on 2023/03/24 17:16:59 UTC
[qpid-proton] branch main updated: PROTON-2691: Additional fixes -Wstrict-prototypes compile warning from Clang (#390)
This is an automated email from the ASF dual-hosted git repository.
jdanek pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git
The following commit(s) were added to refs/heads/main by this push:
new 5db87831c PROTON-2691: Additional fixes -Wstrict-prototypes compile warning from Clang (#390)
5db87831c is described below
commit 5db87831cf38c05364d1597cacbaabd81942048f
Author: Jiri Daněk <jd...@redhat.com>
AuthorDate: Fri Mar 24 18:16:52 2023 +0100
PROTON-2691: Additional fixes -Wstrict-prototypes compile warning from Clang (#390)
---
c/src/messenger/store.c | 2 +-
c/src/messenger/transform.c | 2 +-
c/src/platform/platform.c | 4 ++--
c/src/proactor/epoll.c | 4 ++--
c/src/proactor/libuv.c | 2 +-
c/src/reactor/io/windows/iocp.c | 2 +-
c/src/reactor/io/windows/selector.c | 2 +-
c/src/reactor/reactor.c | 2 +-
c/tools/include/pncompat/internal/getopt.c | 4 ++--
c/tools/msgr-common.c | 4 ++--
10 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/c/src/messenger/store.c b/c/src/messenger/store.c
index 3262cb205..70b2c28cf 100644
--- a/c/src/messenger/store.c
+++ b/c/src/messenger/store.c
@@ -84,7 +84,7 @@ void pni_entry_finalize(void *object)
#define pni_entry_inspect NULL
static const pn_class_t PN_CLASSCLASS(pni_entry) = PN_CLASS(pni_entry);
-pni_store_t *pni_store()
+pni_store_t *pni_store(void)
{
pni_store_t *store = (pni_store_t *) malloc(sizeof(pni_store_t));
if (!store) return NULL;
diff --git a/c/src/messenger/transform.c b/c/src/messenger/transform.c
index 8a5236b18..bd58e2172 100644
--- a/c/src/messenger/transform.c
+++ b/c/src/messenger/transform.c
@@ -81,7 +81,7 @@ static void pn_transform_finalize(void *object)
#define pn_transform_compare NULL
#define pn_transform_inspect NULL
-pn_transform_t *pn_transform()
+pn_transform_t *pn_transform(void)
{
static const pn_class_t clazz = PN_CLASS(pn_transform);
pn_transform_t *transform = (pn_transform_t *) pn_class_new(&clazz, sizeof(pn_transform_t));
diff --git a/c/src/platform/platform.c b/c/src/platform/platform.c
index 5e6a3ac41..105fdc081 100644
--- a/c/src/platform/platform.c
+++ b/c/src/platform/platform.c
@@ -27,12 +27,12 @@
#ifdef PN_WINAPI
#include <windows.h>
-int pn_i_getpid() {
+int pn_i_getpid(void) {
return (int) GetCurrentProcessId();
}
#else
#include <unistd.h>
-int pn_i_getpid() {
+int pn_i_getpid(void) {
return (int) getpid();
}
#endif
diff --git a/c/src/proactor/epoll.c b/c/src/proactor/epoll.c
index ae9971b38..511f36213 100644
--- a/c/src/proactor/epoll.c
+++ b/c/src/proactor/epoll.c
@@ -1495,7 +1495,7 @@ pn_listener_t *pn_event_listener(pn_event_t *e) {
return (pn_event_class(e) == PN_CLASSCLASS(pn_listener)) ? (pn_listener_t*)pn_event_context(e) : NULL;
}
-pn_listener_t *pn_listener() {
+pn_listener_t *pn_listener(void) {
pn_listener_t *l = (pn_listener_t*)calloc(1, sizeof(pn_listener_t));
if (l) {
l->batch.next_event = listener_batch_next;
@@ -1951,7 +1951,7 @@ static void grow_poller_bufs(pn_proactor_t* p) {
ee->wanted = EPOLLIN; // for all subsequent rearms
}
-pn_proactor_t *pn_proactor() {
+pn_proactor_t *pn_proactor(void) {
if (getenv("PNI_EPOLL_NOWARM")) pni_warm_sched = false;
if (getenv("PNI_EPOLL_IMMEDIATE")) pni_immediate = true;
if (getenv("PNI_EPOLL_SPINS")) pni_spins = atoi(getenv("PNI_EPOLL_SPINS"));
diff --git a/c/src/proactor/libuv.c b/c/src/proactor/libuv.c
index aebd4a238..3bc9e77fb 100644
--- a/c/src/proactor/libuv.c
+++ b/c/src/proactor/libuv.c
@@ -1215,7 +1215,7 @@ static void work_free(work_t *w) {
}
}
-pn_proactor_t *pn_proactor() {
+pn_proactor_t *pn_proactor(void) {
uv_once(&global_init_once, global_init_fn);
pn_proactor_t *p = (pn_proactor_t*)calloc(1, sizeof(pn_proactor_t));
p->collector = pn_collector();
diff --git a/c/src/reactor/io/windows/iocp.c b/c/src/reactor/io/windows/iocp.c
index 21fe46d5a..d247e2983 100644
--- a/c/src/reactor/io/windows/iocp.c
+++ b/c/src/reactor/io/windows/iocp.c
@@ -1171,7 +1171,7 @@ void pni_iocp_finalize(void *obj)
pni_shared_pool_free(iocp);
}
-iocp_t *pni_iocp()
+iocp_t *pni_iocp(void)
{
static const pn_class_t clazz = PN_CLASS(pni_iocp);
iocp_t *iocp = (iocp_t *) pn_class_new(&clazz, sizeof(iocp_t));
diff --git a/c/src/reactor/io/windows/selector.c b/c/src/reactor/io/windows/selector.c
index 8c2eb6e62..b1a1cc337 100644
--- a/c/src/reactor/io/windows/selector.c
+++ b/c/src/reactor/io/windows/selector.c
@@ -86,7 +86,7 @@ void pn_selector_finalize(void *obj)
#define pn_selector_compare NULL
#define pn_selector_inspect NULL
-pn_selector_t *pni_selector()
+pn_selector_t *pni_selector(void)
{
static const pn_class_t clazz = PN_CLASS(pn_selector);
pn_selector_t *selector = (pn_selector_t *) pn_class_new(&clazz, sizeof(pn_selector_t));
diff --git a/c/src/reactor/reactor.c b/c/src/reactor/reactor.c
index 340ee7c6b..85e750669 100644
--- a/c/src/reactor/reactor.c
+++ b/c/src/reactor/reactor.c
@@ -107,7 +107,7 @@ static void pn_reactor_finalize(void *object) {
#define pn_reactor_compare NULL
#define pn_reactor_inspect NULL
-pn_reactor_t *pn_reactor() {
+pn_reactor_t *pn_reactor(void) {
static const pn_class_t clazz = PN_CLASS(pn_reactor);
pn_reactor_t *reactor = pn_class_new(&clazz, sizeof(pn_reactor_t));
int err = pn_pipe(reactor->io, reactor->wakeup);
diff --git a/c/tools/include/pncompat/internal/getopt.c b/c/tools/include/pncompat/internal/getopt.c
index 5f24dd808..495981c2f 100644
--- a/c/tools/include/pncompat/internal/getopt.c
+++ b/c/tools/include/pncompat/internal/getopt.c
@@ -57,7 +57,7 @@ static int opt_offset = 0; /* Index into compounded "-option" */
static int dashdash = 0; /* True if "--" option reached */
static int nonopt = 0; /* How many nonopts we've found */
-static void increment_index()
+static void increment_index(void)
{
/* Move onto the next option */
if(argv_index < argv_index2)
@@ -74,7 +74,7 @@ static void increment_index()
* Permutes argv[] so that the argument currently being processed is moved
* to the end.
*/
-static int permute_argv_once()
+static int permute_argv_once(void)
{
/* Movability check */
if(argv_index + nonopt >= prev_argc) return 1;
diff --git a/c/tools/msgr-common.c b/c/tools/msgr-common.c
index e9c285c30..92dd491b2 100644
--- a/c/tools/msgr-common.c
+++ b/c/tools/msgr-common.c
@@ -44,7 +44,7 @@ char *msgr_strdup( const char *src )
}
-pn_timestamp_t msgr_now()
+pn_timestamp_t msgr_now(void)
{
// from "pncompat/misc_funcs.inc"
return time_now();
@@ -159,7 +159,7 @@ void parse_password( const char *input, char **password )
}
static int dolog = 0;
-void enable_logging()
+void enable_logging(void)
{
dolog = 1;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org