You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by mjsax <gi...@git.apache.org> on 2016/01/20 18:43:15 UTC
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
GitHub user mjsax opened a pull request:
https://github.com/apache/storm/pull/1031
[storm-core] Added exception for emit to undeclared stream
`stream->component->grouper` does only contain streams that are not consumed. Thus, I add entries for all streams (with key is `streamID` and `null` as value) to the computed `HashMap` in `outbound-components`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/storm undeclaredStreams
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1031.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1031
----
commit 464da009f4c5a49853147ffb188f9eea2669b3ba
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2016-01-20T17:34:45Z
[storm-core] Added exception for emit to undeclared stream
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1031
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178624815
@mjsax is there a JIRA associated with this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178809384
Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178807187
Thanks @mjsax just merged this into master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178630220
No JIRA. Should I open one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178618849
+1 the change looks fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [storm-core] Added exception for emit to undec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1031#issuecomment-178800030
@mjsax if you want to, if you don't I am happy to merge it in just as a pull request. I just wanted to check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---