You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by cr...@locus.apache.org on 2000/06/12 18:00:55 UTC
cvs commit: jakarta-struts/web/documentation tags.html
craigmcc 00/06/12 09:00:55
Modified: src/share/org/apache/struts/taglib CheckboxTag.java
RadioTag.java
web/documentation tags.html
Log:
Fix the generated HTML for checkboxes and radio buttons to not have the
extra quote mark. Also, correct the documentation of the radio button
tag -- the "value" attribute is required, and it is not currently possible
to use this tag to define a radio button not associated with a particular
property of the underlying form bean.
Ah, the danger of overly aggressive cut-and-paste ... :-(
Submitted by: Ralph Schaer <sc...@ess.ch>
Revision Changes Path
1.2 +4 -4 jakarta-struts/src/share/org/apache/struts/taglib/CheckboxTag.java
Index: CheckboxTag.java
===================================================================
RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/CheckboxTag.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- CheckboxTag.java 2000/05/31 22:28:11 1.1
+++ CheckboxTag.java 2000/06/12 16:00:53 1.2
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/CheckboxTag.java,v 1.1 2000/05/31 22:28:11 craigmcc Exp $
- * $Revision: 1.1 $
- * $Date: 2000/05/31 22:28:11 $
+ * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/CheckboxTag.java,v 1.2 2000/06/12 16:00:53 craigmcc Exp $
+ * $Revision: 1.2 $
+ * $Date: 2000/06/12 16:00:53 $
*
* ====================================================================
*
@@ -77,7 +77,7 @@
* Tag for input fields of type "checkbox".
*
* @author Craig R. McClanahan
- * @version $Revision: 1.1 $ $Date: 2000/05/31 22:28:11 $
+ * @version $Revision: 1.2 $ $Date: 2000/06/12 16:00:53 $
*/
public final class CheckboxTag extends BodyTagSupport {
@@ -165,7 +165,7 @@
// Create an appropriate "input" element based on our parameters
StringBuffer results = new StringBuffer("<input type=\"checkbox\"");
- results.append("\" name=\"");
+ results.append(" name=\"");
results.append(this.name);
results.append("\"");
String value = this.value;
1.2 +4 -4 jakarta-struts/src/share/org/apache/struts/taglib/RadioTag.java
Index: RadioTag.java
===================================================================
RCS file: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/RadioTag.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- RadioTag.java 2000/05/31 22:28:12 1.1
+++ RadioTag.java 2000/06/12 16:00:53 1.2
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/RadioTag.java,v 1.1 2000/05/31 22:28:12 craigmcc Exp $
- * $Revision: 1.1 $
- * $Date: 2000/05/31 22:28:12 $
+ * $Header: /home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/RadioTag.java,v 1.2 2000/06/12 16:00:53 craigmcc Exp $
+ * $Revision: 1.2 $
+ * $Date: 2000/06/12 16:00:53 $
*
* ====================================================================
*
@@ -77,7 +77,7 @@
* Tag for input fields of type "radio".
*
* @author Craig R. McClanahan
- * @version $Revision: 1.1 $ $Date: 2000/05/31 22:28:12 $
+ * @version $Revision: 1.2 $ $Date: 2000/06/12 16:00:53 $
*/
public final class RadioTag extends BodyTagSupport {
@@ -188,7 +188,7 @@
// Create an appropriate "input" element based on our parameters
StringBuffer results = new StringBuffer("<input type=\"radio\"");
- results.append("\" name=\"");
+ results.append(" name=\"");
results.append(this.name);
results.append("\" value=\"");
results.append(this.value);
1.2 +3 -3 jakarta-struts/web/documentation/tags.html
Index: tags.html
===================================================================
RCS file: /home/cvs/jakarta-struts/web/documentation/tags.html,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- tags.html 2000/06/01 21:06:28 1.1
+++ tags.html 2000/06/12 16:00:53 1.2
@@ -582,7 +582,7 @@
<h1><i>radio</i> - Render A Radio Button Input Field</h1>
<p>Renders an HTML <code><input></code> element of type
-<code>radio</code>, populated from the specified value or the specified
+<code>radio</code>, populated from the specified
property of the bean associated with our current <code>form</code>. This
tag is only valid when nested inside a <code>form</code> tag body.</p>
@@ -595,8 +595,8 @@
<td align="center">name</td>
<td>
Name of this input field, and the name of the corresponding bean
- property if <code>value</code> is not specified. The corresponding
- bean property (if any) must be of type <code>boolean</code>.
+ property. The corresponding bean property must be of type
+ <code>String</code>.
</td>
</tr>
<tr>