You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "RosiKyu (via GitHub)" <gi...@apache.org> on 2026/01/19 15:25:17 UTC
[I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
RosiKyu opened a new issue, #12466:
URL: https://github.com/apache/cloudstack/issues/12466
### problem
The `keyword` parameter in the `listBackupOfferings` API is accepted but does not filter results. Regardless of the search term provided, the API returns an empty result set.
### versions
ACS 4.20+
### The steps to reproduce the bug
1. Create multiple backup offerings with distinct names (e.g., "test", "test1", "test2")
2. List all backup offerings - confirms they exist
3. Attempt to filter using the `keyword` parameter
- `list` backupofferings` -> returns all 3 offerings
```
(localcloud) 🐱 > list backupofferings
{
"backupoffering": [
{
"allowuserdrivenbackups": true,
"created": "2026-01-19T15:01:32+0000",
"description": "test",
"externalid": "17fa51d2-8890-481d-9671-c1ba72dfc59b",
"id": "f88854a3-ebd3-42b7-a05b-a5cedb06b10c",
"name": "test",
"provider": "dummy",
"zoneid": "8be3db01-c7d7-4e87-adad-0e26ee771912",
"zonename": "ref-trl-10625-k-Mu22-daman-arora"
},
{
"allowuserdrivenbackups": true,
"created": "2026-01-19T15:01:51+0000",
"description": "test",
"externalid": "ce56bc45-3e6b-42fc-bea6-9dd8311c612e",
"id": "8ae7ba94-2402-4dbb-baa2-438a0ca8499e",
"name": "test1",
"provider": "dummy",
"zoneid": "8be3db01-c7d7-4e87-adad-0e26ee771912",
"zonename": "ref-trl-10625-k-Mu22-daman-arora"
},
{
"allowuserdrivenbackups": true,
"created": "2026-01-19T15:02:01+0000",
"description": "test",
"externalid": "fbddad55-0563-4a51-a7c7-96dfb23cf8e5",
"id": "1c4e6d62-541a-4dc7-b4a6-3e5928fa3c25",
"name": "test2",
"provider": "dummy",
"zoneid": "8be3db01-c7d7-4e87-adad-0e26ee771912",
"zonename": "ref-trl-10625-k-Mu22-daman-arora"
}
],
"count": 3
}
```
- list backupofferings keyword=test -> returns empty
- list backupofferings keyword=test1 -> returns empty
<img width="1798" height="425" alt="Image" src="https://github.com/user-attachments/assets/426fb2c7-d723-4fb5-ae50-704dfe115bc1" />
## Expected Behavior
The `keyword` parameter should filter backup offerings by name, returning offerings that match the search term.
## Actual Behavior
The `keyword` parameter returns empty results regardless of the search term, even when matching offerings exist.
## Environment
- CloudStack version: 4.20+
## Additional Information
- Other filter parameters (`id`, `zoneid`, `pagesize`, `page`) work correctly
- The `keyword` parameter is defined in the API and accepted without error
- This appears to be a bug in the search criteria implementation in `BackupManagerImpl.java`
### What to do about it?
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland closed issue #12466: `listBackupOfferings` API: `keyword` parameter does not filter results
URL: https://github.com/apache/cloudstack/issues/12466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "adithyanms-debug (via GitHub)" <gi...@apache.org>.
adithyanms-debug commented on issue #12466:
URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3799269790
Hi there, I am new to open source contribution is it a good issue to start working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #12466:
URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3811951394
fixed in #12540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #12466:
URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3805754968
@chezsan770 there is a PR ready for this, it just needs backpporting to the 4.20 branch (if the author, @JeevanYewale is willing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "adithyanms-debug (via GitHub)" <gi...@apache.org>.
adithyanms-debug commented on issue #12466:
URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3799617352
@DaanHoogland thanks for letting me know
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "chezsan770 (via GitHub)" <gi...@apache.org>.
chezsan770 commented on issue #12466:
URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3801646921
Hi, I’d like to work on this issue if it’s still open.
Please let me know if I can proceed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "saturn-amarbat (via GitHub)" <gi...@apache.org>.
saturn-amarbat commented on issue #12466:
URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3782535323
Interesting catch on this filtering bug. Looking at the issue, it seems the keyword parameter is accepted by the API but not actually used in the search criteria implementation.
A few thoughts for investigation:
1. The problem is likely in BackupManagerImpl.java where the search logic needs to check if `keyword` is provided and apply it to the name/description filtering
2. Similar list APIs in CloudStack probably handle this correctly - might be worth checking how `listServiceOfferings` or `listComputeOfferings` implement their keyword filtering for reference
3. The reproduction steps are clear - creating a test case with 3 offerings and verifying each keyword returns empty vs the expected filtered result would validate the fix
Worth checking if this is just a missing null/empty check on the keyword parameter or if the filtering logic itself wasn't connected. The fact that other parameters work correctly suggests it's isolated to the keyword implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] `listBackupOfferings` API: `keyword` parameter does not filter results [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #12466:
URL: https://github.com/apache/cloudstack/issues/12466#issuecomment-3799399081
> Hi there, I am new to open source contribution is it a good issue to start working
it would have been for sure @adithyanms-debug , but please see #12480 , it seems to have already been implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org