You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2017/03/25 19:03:41 UTC
[jira] [Commented] (ARROW-711) [C++] Remove extern template
declarations for NumericArray types
[ https://issues.apache.org/jira/browse/ARROW-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941861#comment-15941861 ]
Wes McKinney commented on ARROW-711:
------------------------------------
PR: https://github.com/apache/arrow/pull/441
> [C++] Remove extern template declarations for NumericArray<T> types
> -------------------------------------------------------------------
>
> Key: ARROW-711
> URL: https://issues.apache.org/jira/browse/ARROW-711
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Reporter: Wes McKinney
> Assignee: Wes McKinney
>
> It seems that linkers have diverging semantics around visibility when using the {{extern template}} declaration (see linker errors in https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/build/1.0.841). Since the only thing impacted right now is the {{NumericArray<T>}} constructor, removing these doesn't seem too onerous. I ran the existing benchmarks and looked at the library sizes before and after, and there doesn't appear to be a meaningful difference.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)