You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "TzeKai Lee (JIRA)" <ji...@apache.org> on 2011/06/20 09:01:48 UTC

[jira] [Created] (PROTOCOLS-23) Incorrect counting on connection limit

Incorrect counting on connection limit
--------------------------------------

                 Key: PROTOCOLS-23
                 URL: https://issues.apache.org/jira/browse/PROTOCOLS-23
             Project: JAMES Protocols
          Issue Type: Bug
            Reporter: TzeKai Lee
            Assignee: Norman Maurer


The counter in ConnectionLimitUpstreamHandler and ConnectionPerIpLimitUpstreamHandler will decrease one more than expected when the connection reaches limit, therefore the handler can not really limit connection numbers.
Say, if the limit is set to 2, connections will go like 0 -> 1 -> 2 -> refused -> 3 -> refused -> 4.
And the total connection limit counter is offseted by 1.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Updated] (PROTOCOLS-23) Incorrect counting on connection limit

Posted by "TzeKai Lee (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTOCOLS-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

TzeKai Lee updated PROTOCOLS-23:
--------------------------------

    Attachment: ConnectionLimit.patch

The patch should fix this issue.

> Incorrect counting on connection limit
> --------------------------------------
>
>                 Key: PROTOCOLS-23
>                 URL: https://issues.apache.org/jira/browse/PROTOCOLS-23
>             Project: JAMES Protocols
>          Issue Type: Bug
>            Reporter: TzeKai Lee
>            Assignee: Norman Maurer
>         Attachments: ConnectionLimit.patch
>
>
> The counter in ConnectionLimitUpstreamHandler and ConnectionPerIpLimitUpstreamHandler will decrease one more than expected when the connection reaches limit, therefore the handler can not really limit connection numbers.
> Say, if the limit is set to 2, connections will go like 0 -> 1 -> 2 -> refused -> 3 -> refused -> 4.
> And the total connection limit counter is offseted by 1.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] [Resolved] (PROTOCOLS-23) Incorrect counting on connection limit

Posted by "Norman Maurer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTOCOLS-23?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Norman Maurer resolved PROTOCOLS-23.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4.1

Fixed... Thanks for the patch!

> Incorrect counting on connection limit
> --------------------------------------
>
>                 Key: PROTOCOLS-23
>                 URL: https://issues.apache.org/jira/browse/PROTOCOLS-23
>             Project: JAMES Protocols
>          Issue Type: Bug
>            Reporter: TzeKai Lee
>            Assignee: Norman Maurer
>             Fix For: 1.4.1
>
>         Attachments: ConnectionLimit.patch
>
>
> The counter in ConnectionLimitUpstreamHandler and ConnectionPerIpLimitUpstreamHandler will decrease one more than expected when the connection reaches limit, therefore the handler can not really limit connection numbers.
> Say, if the limit is set to 2, connections will go like 0 -> 1 -> 2 -> refused -> 3 -> refused -> 4.
> And the total connection limit counter is offseted by 1.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org