You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/19 22:24:31 UTC

[GitHub] [incubator-superset] john-bodley opened a new pull request #8261: [migration] Stripping leading and trailing whitespace

john-bodley opened a new pull request #8261: [migration] Stripping leading and trailing whitespace
URL: https://github.com/apache/incubator-superset/pull/8261
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   Similar to https://github.com/apache/incubator-superset/pull/7084 this PR strips leading and trailing whitespace (produced when using the forms) from specific non-NULL string columns. Previously #7084 dealt only with the cases where the values contained _only_ whitespace. 
   
   We ran into this issue when trying to debug a security issue were the table names weren't matching due to trailing whitespace. It seems prudent that the records in Superset's schema be trustworthy and it's more desirable to clean this up via a migration than having to call `.strip()` every time we dealing with records from the database. 
    
   ### TEST PLAN
   
   Ran `superset db upgrade` (and `superset db downgrade`) and verified that the leading and trailing whitespaces were removed. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [x] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org