You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/05/22 16:45:02 UTC

[jira] [Commented] (CLIMATE-440) Remove local PATH_LEADER settings from test_directory_helpers

    [ https://issues.apache.org/jira/browse/CLIMATE-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14005966#comment-14005966 ] 

ASF GitHub Bot commented on CLIMATE-440:
----------------------------------------

GitHub user MJJoyce opened a pull request:

    https://github.com/apache/climate/pull/38

    CLIMATE-440 - Remove local PATH_LEADER settings in directory_helpers

    - Remove all local copies of PATH_LEADER in test_directory_helpers. Now
      the settings in the backend config are used instead.
    - Move PATH_LEADER creation to the test package wide setup function.
      Remove the explicit removes present in test_directory_helpers.
    - Remove hardcoded WORK_DIR value in package wide setup function. Now
      the value set in config is used instead.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MJJoyce/climate CLIMATE-440

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/38.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #38
    
----
commit dbd6bf4e20874fdfefd153a72ce9f2c8375c0a4d
Author: Michael Joyce <jo...@apache.org>
Date:   2014-05-22T14:40:11Z

    CLIMATE-440 - Remove local PATH_LEADER settings in directory_helpers
    
    - Remove all local copies of PATH_LEADER in test_directory_helpers. Now
      the settings in the backend config are used instead.
    - Move PATH_LEADER creation to the test package wide setup function.
      Remove the explicit removes present in test_directory_helpers.
    - Remove hardcoded WORK_DIR value in package wide setup function. Now
      the value set in config is used instead.

----


> Remove local PATH_LEADER settings from test_directory_helpers
> -------------------------------------------------------------
>
>                 Key: CLIMATE-440
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-440
>             Project: Apache Open Climate Workbench
>          Issue Type: Bug
>          Components: webapp
>    Affects Versions: 0.3-incubating
>            Reporter: Michael Joyce
>            Assignee: Michael Joyce
>             Fix For: 0.4
>
>
> Some of the tests in test_directory_helpers use a custom PATH_LEADER variable instead of the one present in config.py. All these references need to be removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)