You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2026/03/23 19:29:48 UTC

[PR] Fix conf import to common.compat [airflow]

eladkal opened a new pull request, #64118:
URL: https://github.com/apache/airflow/pull/64118

   The import should be from common.compat


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix conf import to common.compat in `ElasticsearchTaskHandler` [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #64118:
URL: https://github.com/apache/airflow/pull/64118#discussion_r2977370075


##########
providers/elasticsearch/pyproject.toml:
##########
@@ -60,9 +60,9 @@ requires-python = ">=3.10"
 # After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
 dependencies = [
     "apache-airflow>=2.11.0",
-    "apache-airflow-providers-common-compat>=1.12.0",
+    "apache-airflow-providers-common-compat>=1.12.0", # use next version

Review Comment:
   I _think_ the `conf` was already available in 1.12.0, so no need to bump version.
   
   See https://github.com/boschglobal/airflow/blob/acffa62713874bc64db3f6447840cf171114476f/providers/common/compat/src/airflow/providers/common/compat/sdk.py#L80



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix conf import to common.compat in `ElasticsearchTaskHandler` [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #64118:
URL: https://github.com/apache/airflow/pull/64118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix conf import to common.compat in `ElasticsearchTaskHandler` [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #64118:
URL: https://github.com/apache/airflow/pull/64118#discussion_r2977383037


##########
providers/elasticsearch/pyproject.toml:
##########
@@ -60,9 +60,9 @@ requires-python = ">=3.10"
 # After you modify the dependencies, and rebuild your Breeze CI image with ``breeze ci-image build``
 dependencies = [
     "apache-airflow>=2.11.0",
-    "apache-airflow-providers-common-compat>=1.12.0",
+    "apache-airflow-providers-common-compat>=1.12.0", # use next version

Review Comment:
   ```suggestion
       "apache-airflow-providers-common-compat>=1.12.0",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org