Re: [ws-xmlrpc|codec] ws-xmlrpc fails on Gump when compiling against codec ...

["Adam R. B. Jack" <aj...@trysybase.com>]

Could somebody with commit privileges simple remove this try/catch?

>
/data3/gump/ws-xmlrpc/src/java/org/apache/xmlrpc/DefaultTypeFactory.java:133
> : exception org.apache.commons.codec.DecoderException is never thrown in

>      try {
>             return base64Codec.decode(cdata.getBytes());
>         }
>         catch (DecoderException e) {
>             //TODO: consider throwing an exception here?
>             return new byte[0];
>         }


The explanation of why it is correct to remove it has been sent to this
list.

The reason  ask is that 65 projects are waiting on this fix for Gump
coverage:
.. making ws-xmlrpc the #1-affecting-project-of-the-day:

    http://brutus.apache.org:8080/gump/project_todos.html

Thanks in advance.

regards

Adam
----- Original Message ----- 
From: "Adam R. B. Jack" <aj...@trysybase.com>
To: <xm...@ws.apache.org>; "Jakarta Commons Developers List"
<co...@jakarta.apache.org>
Cc: "Gump code and data" <ge...@gump.apache.org>
Sent: Friday, March 05, 2004 6:11 PM
Subject: [ws-xmlrpc|codec] ws-xmlrpc fails on Gump when compiling against
codec ...


> ws-xmlrpc recently started failing to be Gumped against codec, see:
>
> http://lsd.student.utwente.nl/gump/ws-xmlrpc/ws-xmlrpc.html
>
> inside the build:
>
>
http://lsd.student.utwente.nl/gump/ws-xmlrpc/gump_work/build_ws-xmlrpc_ws-xmlrpc.html
>
> stating:
>
> [javac]
>
/data3/gump/ws-xmlrpc/src/java/org/apache/xmlrpc/DefaultTypeFactory.java:133
> : exception org.apache.commons.codec.DecoderException is never thrown in
> body of corresponding try statement
>     [javac]         catch (DecoderException e) {
>     [javac]         ^
>
> This confused me, because looking in CVS the createBase64() method in:
>
>
http://cvs.apache.org/viewcvs.cgi/ws-xmlrpc/src/java/org/apache/xmlrpc/DefaultTypeFactory.java
>
> has
>
>      try {
>             return base64Codec.decode(cdata.getBytes());
>         }
>         catch (DecoderException e) {
>             //TODO: consider throwing an exception here?
>             return new byte[0];
>         }
>
> But the decode() method in this class does state it could throw:
>
>     org.apache.commons.codec.DecoderException
>
> see:
>
>
http://cvs.apache.org/viewcvs.cgi/jakarta-commons/codec/src/java/org/apache/commons/codec/binary/Base64.java
>
> Does anybody see anything I'm missing?
>
> regards
>
> Adam
> --
> Experience the Unwired Enterprise:
> http://www.sybase.com/unwiredenterprise
> Try Sybase: http://www.try.sybase.com
>