You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/07/22 15:18:48 UTC

[GitHub] [hbase] Apache9 commented on a diff in pull request #4640: HBASE-27232 Fix checking for encoded block size when deciding if bloc…

Apache9 commented on code in PR #4640:
URL: https://github.com/apache/hbase/pull/4640#discussion_r927756004


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##########
@@ -449,7 +449,7 @@ public int getOnDiskSizeWithHeader() {
   }
 
   /** Returns the on-disk size of the data part + checksum (header excluded). */
-  int getOnDiskSizeWithoutHeader() {
+  public int getOnDiskSizeWithoutHeader() {

Review Comment:
   Why do we need to change this modifier? Seems we do not call in the newly added tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org