You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by "tanclary (via GitHub)" <gi...@apache.org> on 2023/08/22 16:18:02 UTC

[GitHub] [calcite] tanclary commented on pull request #3378: [CALCITE-5770] Add SAFE_SUBTRACT function (enabled in BigQuery library)

tanclary commented on PR #3378:
URL: https://github.com/apache/calcite/pull/3378#issuecomment-1688522551

   @JiajunBernoulli @zoudan Thank you both for your comments, I have dropped the SAFE_DIVIDE commit from this PR to make it more clear. The expression parameters tests will be added in the SAFE_DIVIDE PR. Let me know if you have any other comments about SAFE_SUBTRACT, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org