You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by dcristoloveanu <gi...@git.apache.org> on 2015/04/28 02:46:34 UTC

[GitHub] qpid-proton pull request: Fix none_sasl.c to use pn_strdup instead...

GitHub user dcristoloveanu opened a pull request:

    https://github.com/apache/qpid-proton/pull/24

    Fix none_sasl.c to use pn_strdup instead of strdup

    (PROTON-870) none_sasl.c should use pn_strdup.
    
    none_sasl.c uses strdup, but strdup is not part of C99 and subsequently does not exist on some platforms. Instead pn_strdup should be used.
    
    Thanks,
    /Dan

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dcristoloveanu/qpid-proton NoneSASL

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-proton/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit 300ffc4246f0007a70b40954e29fbbe44796ad74
Author: dcristoloveanu <dc...@microsoft.com>
Date:   2015-04-28T00:44:05Z

    Fix none_sasl.c to use pn_strdup instead of strdup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] qpid-proton pull request: Fix none_sasl.c to use pn_strdup instead...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/qpid-proton/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] qpid-proton pull request: Fix none_sasl.c to use pn_strdup instead...

Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the pull request:

    https://github.com/apache/qpid-proton/pull/24#issuecomment-96902826
  
    Oops


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---