[GitHub] [incubator-pegasus] acelyc111 commented on a change in pull request #601: feat(hotspot): add a function to start hotkey detecting in hotspot_partition_calculator

[GitBox <gi...@apache.org>]

acelyc111 commented on a change in pull request #601:
URL: https://github.com/apache/incubator-pegasus/pull/601#discussion_r487631987



##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -98,5 +103,49 @@ void hotspot_partition_calculator::data_analyse()
     }
 }
 
+/*static*/ void hotspot_partition_calculator::server_hotkey_detect_send(

Review comment:
       How about rename this function to `send_hotkey_detect_request` ?

##########
File path: src/server/hotspot_partition_calculator.h
##########
@@ -37,6 +49,10 @@ class hotspot_partition_calculator
     void data_aggregate(const std::vector<row_data> &partitions);
     // analyse the saved data to find hotspot partition
     void data_analyse();
+    static void server_hotkey_detect_send(const std::string &app_name,
+                                          const int partition_index,
+                                          const hotkey_detect_type type,
+                                          const hotkey_detect_action operation);

Review comment:
       ```suggestion
                                             const hotkey_detect_action action);
   ```

##########
File path: src/server/hotspot_partition_calculator.cpp
##########
@@ -98,5 +103,49 @@ void hotspot_partition_calculator::data_analyse()
     }
 }
 
+/*static*/ void hotspot_partition_calculator::server_hotkey_detect_send(
+    const std::string &app_name,
+    const int partition_index,
+    const hotkey_detect_type write_hotkey_detect,
+    const hotkey_detect_action stop_detect_hotkey)

Review comment:
       ```suggestion
       const hotkey_detect_action action)
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org