[jira] [Comment Edited] (CASSANDRA-5385) IndexHelper.skipBloomFilters won't skip non-SHA filters

["Jason Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-5385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13614449#comment-13614449 ] 

Jason Brown edited comment on CASSANDRA-5385 at 3/26/13 7:25 PM:
-----------------------------------------------------------------

LGTM. Nice catch, will commit in a few minutes. Thanks!

EDIT: actually, looking into a side question that carl raised about OOM problem.
                
      was (Author: jasobrown):
    LGTM. Nice catch, will commit in a few minutes. Thanks!
                  
> IndexHelper.skipBloomFilters won't skip non-SHA filters
> -------------------------------------------------------
>
>                 Key: CASSANDRA-5385
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5385
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Carl Yeksigian
>            Assignee: Carl Yeksigian
>             Fix For: 2.0
>
>         Attachments: 5385.patch
>
>
> Currently, if the bloom filter is not of SHA type, we do not properly skip the bytes. We need to read out the number of bytes, as happens in the Murmur deserializer, then skip that many bytes instead of just skipping the hash size. The version needs to be passed into the method as well, so that it knows what type of index it is, and does the appropriate skipping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira