You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2020/12/04 22:32:14 UTC

[GitHub] [avro] areese opened a new pull request #1033: Fix 2 typos in lang/c++/api/ValidSchema.hh:

areese opened a new pull request #1033:
URL: https://github.com/apache/avro/pull/1033


   1. minumum -> minimum
   2. valididated -> validated
   
   Fix 1 typo in lang/c++/api/GenericDatum.hh:
   1. appropraite ->  appropriate
   
   Fix 3 typos in lang/c++/api/Decoder.hh:
   1. fiedls -> fields
   2. arbitray -> arbitrary
   3. funtions -> functions
   
   Fix 3 typos in lang/c++/api/DataFile.hh:
   1. opportinity -> opportunity
   2. entires -> entries
   3. desrialize -> deserialize
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: 
        This PR only fixes typo's in the c++ documentation built from the comments.
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba commented on pull request #1033: Fix 2 typos in lang/c++/api/ValidSchema.hh:

Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1033:
URL: https://github.com/apache/avro/pull/1033#issuecomment-760967597


   Thanks for this improvement!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] RyanSkraba merged pull request #1033: Fix 2 typos in lang/c++/api/ValidSchema.hh:

Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1033:
URL: https://github.com/apache/avro/pull/1033


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] areese commented on pull request #1033: Fix 2 typos in lang/c++/api/ValidSchema.hh:

Posted by GitBox <gi...@apache.org>.
areese commented on pull request #1033:
URL: https://github.com/apache/avro/pull/1033#issuecomment-740016258


   Travis build failed to download artifacts from maven under java 8:
   ```
   [ERROR] Failed to execute goal on project avro-grpc: Could not resolve dependencies for project org.apache.avro:avro-grpc:bundle:1.11.0-SNAPSHOT: Failed to collect dependencies at io.grpc:grpc-core:jar:1.33.1: Failed to read artifact descriptor for io.grpc:grpc-core:jar:1.33.1: Could not transfer artifact io.grpc:grpc-core:pom:1.33.1 from/to central (https://repo.maven.apache.org/maven2): Transfer failed for https://repo.maven.apache.org/maven2/io/grpc/grpc-core/1.33.1/grpc-core-1.33.1.pom: Connection reset -> [Help 1]
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org