You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "findepi (via GitHub)" <gi...@apache.org> on 2025/09/03 13:11:34 UTC

[PR] Fix PartialOrd for Window [datafusion]

findepi opened a new pull request, #17393:
URL: https://github.com/apache/datafusion/pull/17393

   Before the changes, `PartialOrd` could return `Some(Equal)` for two `Window` nodes that are not equal in `PartialEq` sense. This is violation of `PartialOrd` contract.
   
   The fix is to consult eq inside ord implementation. If ord thinks two instances are equal, but they are not equal in Eq sense, they are considered incomparable.
   
   - follows https://github.com/apache/datafusion/pull/17182
   - for https://github.com/apache/datafusion/issues/17064


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix PartialOrd for Window [datafusion]

Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi commented on PR #17393:
URL: https://github.com/apache/datafusion/pull/17393#issuecomment-3252992742

   added a test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Fix PartialOrd for Window [datafusion]

Posted by "findepi (via GitHub)" <gi...@apache.org>.
findepi merged PR #17393:
URL: https://github.com/apache/datafusion/pull/17393


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org