You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/08/27 06:51:24 UTC
[kudu-CR] [cfile] Fix the default encoding mappings
lingbinlb@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14147
Change subject: [cfile] Fix the default encoding mappings
......................................................................
[cfile] Fix the default encoding mappings
For any data-type, the first encoding-type added to the map is
the default encoding for that data-type.
Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
---
M src/kudu/cfile/type_encodings.cc
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14147/1
--
To view, visit http://gerrit.cloudera.org:8080/14147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
Gerrit-Change-Number: 14147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
[kudu-CR] [cfile] Fix the default encoding mappings
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14147 )
Change subject: [cfile] Fix the default encoding mappings
......................................................................
[cfile] Fix the default encoding mappings
For any data-type, the first encoding-type added to the map is
the default encoding for that data-type.
Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
Reviewed-on: http://gerrit.cloudera.org:8080/14147
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/cfile/type_encodings.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
Gerrit-Change-Number: 14147
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [cfile] Fix the default encoding mappings
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14147
to look at the new patch set (#2).
Change subject: [cfile] Fix the default encoding mappings
......................................................................
[cfile] Fix the default encoding mappings
For any data-type, the first encoding-type added to the map is
the default encoding for that data-type.
Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
---
M src/kudu/cfile/type_encodings.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/14147/2
--
To view, visit http://gerrit.cloudera.org:8080/14147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
Gerrit-Change-Number: 14147
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [cfile] Fix the default encoding mappings
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14147 )
Change subject: [cfile] Fix the default encoding mappings
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
Gerrit-Change-Number: 14147
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 Aug 2019 18:39:01 +0000
Gerrit-HasComments: No
[kudu-CR] [cfile] Fix the default encoding mappings
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14147 )
Change subject: [cfile] Fix the default encoding mappings
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14147/1/src/kudu/cfile/type_encodings.cc
File src/kudu/cfile/type_encodings.cc:
http://gerrit.cloudera.org:8080/#/c/14147/1/src/kudu/cfile/type_encodings.cc@284
PS1, Line 284: if (default_mapping_.find(type) == default_mapping_.end()) {
Could you use ContainsKey from gutil/map-util.h? It's more idiomatic.
Alternatively, you could avoid the find() altogether: emplace() will no-op if the key is already present, so if we guarantee that the first call to AddMapping for a given data-type is always the default one, we can blindly call emplace() here.
--
To view, visit http://gerrit.cloudera.org:8080/14147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
Gerrit-Change-Number: 14147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 27 Aug 2019 18:34:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] [cfile] Fix the default encoding mappings
Posted by "Anonymous Coward (Code Review)" <ge...@cloudera.org>.
lingbinlb@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/14147 )
Change subject: [cfile] Fix the default encoding mappings
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14147/1/src/kudu/cfile/type_encodings.cc
File src/kudu/cfile/type_encodings.cc:
http://gerrit.cloudera.org:8080/#/c/14147/1/src/kudu/cfile/type_encodings.cc@284
PS1, Line 284: if (default_mapping_.find(type) == default_mapping_.end()) {
> Could you use ContainsKey from gutil/map-util.h? It's more idiomatic.
Done
--
To view, visit http://gerrit.cloudera.org:8080/14147
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I646715b939a5222b8178117234d9f2acf3c550df
Gerrit-Change-Number: 14147
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <li...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 Aug 2019 03:14:41 +0000
Gerrit-HasComments: Yes