You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2018/08/31 15:59:39 UTC

[GitHub] sachouche commented on a change in pull request #1168: DRILL-6246: Reduced the size of the jdbc-all jar file

sachouche commented on a change in pull request #1168: DRILL-6246: Reduced the size of the jdbc-all jar file
URL: https://github.com/apache/drill/pull/1168#discussion_r214400625
 
 

 ##########
 File path: exec/jdbc-all/pom.xml
 ##########
 @@ -473,6 +473,8 @@
                <exclude>org/yaml/**</exclude>
                <exclude>hello/**</exclude>
                <exclude>webapps/**</exclude>
+               <exclude>**/org/apache/calcite/avatica/metrics/**</exclude>
+               <exclude>**/org/apache/calcite/avatica/org/**</exclude>
 
 Review comment:
   The problem with this PR is that running the test-suite is not enough; as @parthchandra indicated We need to setup few tools and run metadata / DDL & DML queries (involving complex data) to ensure there are no regressions. I am afraid this kind of optimizations will not be easy to include unless we automate the JDBC testing process. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services