You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/19 05:44:52 UTC
[GitHub] [camel-k-examples] KuthumiPepple opened a new pull request, #65: improve readme
KuthumiPepple opened a new pull request, #65:
URL: https://github.com/apache/camel-k-examples/pull/65
@tadayosi @Delawen I added more information to the readme. The examples run as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] KuthumiPepple commented on a diff in pull request #65: improve readme
Posted by GitBox <gi...@apache.org>.
KuthumiPepple commented on code in PR #65:
URL: https://github.com/apache/camel-k-examples/pull/65#discussion_r949997039
##########
generic-examples/languages/README.md:
##########
@@ -1,3 +1,23 @@
-# Supported languages Camel K examples
+# Supported languages for writing Camel K integrations
-Find useful examples about how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML` and `YAML`.
\ No newline at end of file
+Contains useful examples on how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML`, `Kotlin` and `YAML`.
+
+You can find more information about Apache Camel and Apache Camel K on the [official Camel website](https://camel.apache.org).
+
+## Before you begin
+
+Read the general instructions in the [root README.md file](/README.md) for setting up your environment and the Kubernetes cluster before looking at this example.
+
+Make sure you've read the [installation instructions](https://camel.apache.org/camel-k/latest/installation/installation.html) for your specific
+cluster before starting the example.
+
+## Understanding the examples
+- [routes.kts](./routes.kts): defines a route that logs a message every second
+- [routes.yaml](./hello.xml): defines a route that every 5 secs, transforms the message content to uppercase and logs it.
+- [simple.js](./simple.js): logs message periodically, the multiline query parameter is set to true, thus each information is output on a newline
Review Comment:
I felt like the ones I left out were a bit similar to the ones I described. But you are right, we are showing the supported languages, so they should all be described. Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] KuthumiPepple commented on a diff in pull request #65: improve readme
Posted by GitBox <gi...@apache.org>.
KuthumiPepple commented on code in PR #65:
URL: https://github.com/apache/camel-k-examples/pull/65#discussion_r949996610
##########
generic-examples/languages/README.md:
##########
@@ -1,3 +1,23 @@
-# Supported languages Camel K examples
+# Supported languages for writing Camel K integrations
-Find useful examples about how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML` and `YAML`.
\ No newline at end of file
+Contains useful examples on how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML`, `Kotlin` and `YAML`.
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] tadayosi commented on a diff in pull request #65: improve readme
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #65:
URL: https://github.com/apache/camel-k-examples/pull/65#discussion_r949925210
##########
generic-examples/languages/README.md:
##########
@@ -1,3 +1,23 @@
-# Supported languages Camel K examples
+# Supported languages for writing Camel K integrations
-Find useful examples about how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML` and `YAML`.
\ No newline at end of file
+Contains useful examples on how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML`, `Kotlin` and `YAML`.
+
+You can find more information about Apache Camel and Apache Camel K on the [official Camel website](https://camel.apache.org).
+
+## Before you begin
+
+Read the general instructions in the [root README.md file](/README.md) for setting up your environment and the Kubernetes cluster before looking at this example.
+
+Make sure you've read the [installation instructions](https://camel.apache.org/camel-k/latest/installation/installation.html) for your specific
+cluster before starting the example.
+
+## Understanding the examples
+- [routes.kts](./routes.kts): defines a route that logs a message every second
+- [routes.yaml](./hello.xml): defines a route that every 5 secs, transforms the message content to uppercase and logs it.
+- [simple.js](./simple.js): logs message periodically, the multiline query parameter is set to true, thus each information is output on a newline
Review Comment:
There are more examples here. Why only these three?
##########
generic-examples/languages/README.md:
##########
@@ -1,3 +1,23 @@
-# Supported languages Camel K examples
+# Supported languages for writing Camel K integrations
-Find useful examples about how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML` and `YAML`.
\ No newline at end of file
+Contains useful examples on how to develop a Camel K integration in `Java`, `Javascript`, `Groovy`, `XML`, `Kotlin` and `YAML`.
Review Comment:
A bit nitpicky but it should be `JavaScript`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] tadayosi merged pull request #65: improve readme
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #65:
URL: https://github.com/apache/camel-k-examples/pull/65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k-examples] Delawen commented on pull request #65: improve readme
Posted by GitBox <gi...@apache.org>.
Delawen commented on PR #65:
URL: https://github.com/apache/camel-k-examples/pull/65#issuecomment-1220297892
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org