[GitHub] [dubbo-go] zhaoyunxing92 commented on a change in pull request #1513: Ftr: support custom registry group name on nacos for 1.5

[GitBox <gi...@apache.org>]

zhaoyunxing92 commented on a change in pull request #1513:
URL: https://github.com/apache/dubbo-go/pull/1513#discussion_r727027633



##########
File path: registry/nacos/listener.go
##########
@@ -183,12 +183,24 @@ func getSubscribeName(url *common.URL) string {
 	return buffer.String()
 }
 
+func getSubscribeGroupName(url *common.URL) string {

Review comment:
       不应该改这里可以看下,NewNacosListener的时候把url传递下去
   ```go
   func (nr *nacosRegistry) subscribe(conf *common.URL) (registry.Listener, error) {
   	return NewNacosListener(conf, nr.namingClient)
   }
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org