You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/23 22:06:42 UTC
[GitHub] [camel-k] claudio4j opened a new pull request, #3838: Fix tests related to recent camel-k-runtime changes
claudio4j opened a new pull request, #3838:
URL: https://github.com/apache/camel-k/pull/3838
The following PR brought knative from camel-quarkus
https://github.com/apache/camel-k-runtime/pull/927
There is an additional merged PR in camel-k-runtime
https://github.com/apache/camel-k-runtime/pull/933
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on a diff in pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#discussion_r1032763796
##########
pkg/util/dsl/template.go:
##########
@@ -41,7 +41,7 @@ func TemplateToYamlDSL(template v1.Template, id string) ([]byte, error) {
jsondata["id"] = id
}
templateWrapper := make(map[string]interface{}, 2)
- templateWrapper["template"] = jsondata
Review Comment:
+1 for me, I'll wait for @squakez advice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1325771947
The failing test `TestRuntimeContainsEmbeddedArtifacts` is occurring because camel-k-maven-plugin-1.16.0-SNAPSHOT artifact doesn't contain the [fix](https://github.com/apache/camel-k-runtime/pull/933). Probably next camel-k-runtime snapshot build will contain the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1327863584
> It could be that using the default timeout (60s) for this line is too short for snapshot dependencies: https://github.com/apache/camel-k/blob/main/e2e/namespace/upgrade/cli_upgrade_test.go#L94
Agree, let's merge and see next CI test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1326345122
Some other issue is related to the change in the yaml specification: https://camel.apache.org/manual/camel-3x-upgrade-guide-3_19.html#_camel_yaml_dsl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1326171992
@oscerd @claudio4j it seems something is failing when running in native mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1326373929
I am having a look at these tests, thanks @squakez
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1328711625
Let's merge, so we can try to release this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1326009638
@claudio4j There are a bit more places where they still use `camel-k-knative` in E2E tests:
> Error: 4: > {"level":"error","ts":1669269776.4805422,"logger":"camel-k.maven.build","msg":"[ERROR] Some problems were encountered while processing the POMs:\n[ERROR] 'dependencies.dependency.version' for org.apache.camel.k:camel-k-knative:jar is missing. @ line 25, column 17\n @ ","stacktrace":"github.com/apache/camel-k/pkg/util/log.Logger.Error\n\tgithub.com/apache/camel-k/pkg/util/log/log.go:75\ngithub.com/apache/camel-k/pkg/util/maven.normalizeLog\n\tgithub.com/apache/camel-k/pkg/util/maven/maven_log.go:83\ngithub.com/apache/camel-k/pkg/util/maven.mavenLogHandler\n\tgithub.com/apache/camel-k/pkg/util/maven/maven_log.go:54\ngithub.com/apache/camel-k/pkg/util.scan\n\tgithub.com/apache/camel-k/pkg/util/command.go:77\ngithub.com/apache/camel-k/pkg/util.RunAndLog.func1\n\tgithub.com/apache/camel-k/pkg/util/command.go:56\ngolang.org/x/sync/errgroup.(*Group).Go.func1\n\tgolang.org/x/sync@v0.1.0/errgroup/errgroup.go:75"}
Like:
```
$ ag camel-k-knative e2e/
e2e/global/builder/build_test.go
54: "camel-k-knative",
e2e/global/knative/knative_platform_test.go
50: operatorID := "camel-k-knative"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1326125127
I've restarted the checks. At this time, the new snapshot is released. For the future. We need to wait that the camel k runtime PR is merged into `main` and also wait that the build is run once that PR is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#discussion_r1033245641
##########
pkg/util/dsl/template.go:
##########
@@ -41,7 +41,7 @@ func TemplateToYamlDSL(template v1.Template, id string) ([]byte, error) {
jsondata["id"] = id
}
templateWrapper := make(map[string]interface{}, 2)
- templateWrapper["template"] = jsondata
Review Comment:
Thanks. I had a deeper look and it seems that `template` is no longer there. So we should we good with `route-template`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#issuecomment-1327085580
About this `upgrade` failure:
https://github.com/apache/camel-k/actions/runs/3545561937/jobs/5953803406
```
cli_upgrade_test.go:94:
Timed out after 60.020s.
Expected
<string>:
to equal
<string>: 1.11.0-SNAPSHOT
```
It could be that using the default timeout (60s) for this line is too short for snapshot dependencies:
https://github.com/apache/camel-k/blob/main/e2e/namespace/upgrade/cli_upgrade_test.go#L94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
squakez commented on code in PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#discussion_r1032127414
##########
pkg/util/dsl/template.go:
##########
@@ -41,7 +41,7 @@ func TemplateToYamlDSL(template v1.Template, id string) ([]byte, error) {
jsondata["id"] = id
}
templateWrapper := make(map[string]interface{}, 2)
- templateWrapper["template"] = jsondata
Review Comment:
I think the usage of template is still good. However, instead of being an array (therefore a list in yaml) it should be a single parameter of the spec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] claudio4j commented on a diff in pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
claudio4j commented on code in PR #3838:
URL: https://github.com/apache/camel-k/pull/3838#discussion_r1032722760
##########
pkg/util/dsl/template.go:
##########
@@ -41,7 +41,7 @@ func TemplateToYamlDSL(template v1.Template, id string) ([]byte, error) {
jsondata["id"] = id
}
templateWrapper := make(map[string]interface{}, 2)
- templateWrapper["template"] = jsondata
Review Comment:
I removed the array, but that bring a conversion error in camel yaml dsl. To proceed with having `main` in a good state, can we merge as it is, and we can review this array later ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd merged pull request #3838: Fix tests related to recent camel-k-runtime changes
Posted by GitBox <gi...@apache.org>.
oscerd merged PR #3838:
URL: https://github.com/apache/camel-k/pull/3838
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org