You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xiaoxiang781216 (via GitHub)" <gi...@apache.org> on 2023/08/22 05:50:59 UTC
[GitHub] [nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1957: benchmarks/coremark: update SEED_METHOD/MEM_METHOD and debug
xiaoxiang781216 commented on code in PR #1957:
URL: https://github.com/apache/nuttx-apps/pull/1957#discussion_r1300987369
##########
benchmarks/coremark/Kconfig:
##########
@@ -27,6 +27,32 @@ config COREMARK_STACKSIZE
int "CoreMark task stack size"
default 4096
+config COREMARK_SEED_METHOD
+ int "Coremark Seed Method"
+ default 2
+ ---help---
+ Set Coremark Seed Method:
+ 0: SEED_ARG
+ 1: SEED_FUNC
+ 2: SEED_VOLATILE
+
+config COREMARK_MEM_METHOD
+ int "Coremark Memory Method"
+ default 1
+ ---help---
+ Set Coremark Memory Method:
+ 0: MEM_STATIC
+ 1: MEM_MALLOC
+ 2: MEM_STACK
Review Comment:
add
```
config COREMARK_MEM_LOCATION
string
default "global" if COREMARK_MEM_METHOD == 0
default "heap" if COREMARK_MEM_METHOD == 1
default "stack" if COREMARK_MEM_METHOD == 2
```
##########
benchmarks/coremark/Makefile:
##########
@@ -57,14 +57,24 @@ else
COREMARK_PRINT_ARGS = 0
endif
-CFLAGS += ${DEFINE_PREFIX}USE_PTHREAD ${DEFINE_PREFIX}PERFORMANCE_RUN=1
-CFLAGS += ${DEFINE_PREFIX}MULTITHREAD=$(COREMARK_NTHREADS)
+CFLAGS += ${DEFINE_PREFIX}CALLGRIND_RUN=0
+CFLAGS += ${DEFINE_PREFIX}COMPILER_REQUIRES_SORT_RETURN=0
+CFLAGS += ${DEFINE_PREFIX}CORE_DEBUG=$(CONFIG_COREMARK_DEBUG)
CFLAGS += ${DEFINE_PREFIX}FLAGS_STR=\""$(ARCHOPTIMIZATION)\""
-CFLAGS += ${DEFINE_PREFIX}PRINT_ARGS=$(COREMARK_PRINT_ARGS)
CFLAGS += ${DEFINE_PREFIX}MEM_LOCATION=\"Stack\"
+CFLAGS += ${DEFINE_PREFIX}MEM_METHOD=$(CONFIG_COREMARK_MEM_METHOD)
+CFLAGS += ${DEFINE_PREFIX}MICA=0
+CFLAGS += ${DEFINE_PREFIX}PRINT_ARGS=0
+CFLAGS += ${DEFINE_PREFIX}MULTITHREAD=$(COREMARK_NTHREADS)
+CFLAGS += ${DEFINE_PREFIX}PRINT_ARGS=$(COREMARK_PRINT_ARGS)
+CFLAGS += ${DEFINE_PREFIX}SEED_METHOD=$(CONFIG_COREMARK_SEED_METHOD)
+CFLAGS += ${DEFINE_PREFIX}USE_CLOCK=1
+CFLAGS += ${DEFINE_PREFIX}USE_PTHREAD ${DEFINE_PREFIX}PERFORMANCE_RUN=1
Review Comment:
```
CFLAGS += ${DEFINE_PREFIX}MULTITHREAD=$(COREMARK_NTHREADS)
CFLAGS += ${DEFINE_PREFIX}PERFORMANCE_RUN=1
CFLAGS += ${DEFINE_PREFIX}PRINT_ARGS=$(COREMARK_PRINT_ARGS)
CFLAGS += ${DEFINE_PREFIX}SEED_METHOD=$(CONFIG_COREMARK_SEED_METHOD)
CFLAGS += ${DEFINE_PREFIX}USE_CLOCK=1
CFLAGS += ${DEFINE_PREFIX}USE_PTHREAD
```
##########
benchmarks/coremark/Makefile:
##########
@@ -57,14 +57,24 @@ else
COREMARK_PRINT_ARGS = 0
endif
-CFLAGS += ${DEFINE_PREFIX}USE_PTHREAD ${DEFINE_PREFIX}PERFORMANCE_RUN=1
-CFLAGS += ${DEFINE_PREFIX}MULTITHREAD=$(COREMARK_NTHREADS)
+CFLAGS += ${DEFINE_PREFIX}CALLGRIND_RUN=0
+CFLAGS += ${DEFINE_PREFIX}COMPILER_REQUIRES_SORT_RETURN=0
+CFLAGS += ${DEFINE_PREFIX}CORE_DEBUG=$(CONFIG_COREMARK_DEBUG)
CFLAGS += ${DEFINE_PREFIX}FLAGS_STR=\""$(ARCHOPTIMIZATION)\""
-CFLAGS += ${DEFINE_PREFIX}PRINT_ARGS=$(COREMARK_PRINT_ARGS)
CFLAGS += ${DEFINE_PREFIX}MEM_LOCATION=\"Stack\"
Review Comment:
```suggestion
CFLAGS += ${DEFINE_PREFIX}MEM_LOCATION=CONFIG_COREMARK_MEM_LOCATION
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org