[jira] [Closed] (OAK-3519) Some improvement to SyncMBeanImpl

["Davide Giannella (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-3519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davide Giannella closed OAK-3519.
---------------------------------

Bulk close for 1.3.13

> Some improvement to SyncMBeanImpl
> ---------------------------------
>
>                 Key: OAK-3519
>                 URL: https://issues.apache.org/jira/browse/OAK-3519
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: auth-external
>            Reporter: angela
>            Assignee: angela
>            Priority: Minor
>             Fix For: 1.3.13
>
>         Attachments: OAK-3519.patch, OAK-3519_2.patch, OAK-3519_3.patch
>
>
> IMHO the {{SyncMBeanImpl}} deserves some improvement:
> - code duplication
> - overall readability
> - removing catching {{Exception}}
> - throwing {{IllegalArgument}} when no argument has been provided instead of a dedicated {{RuntimeException}} indicating that the operation could not be successfully completed
> - more consistency in variable naming (e.g. the list of strings computed in the various operations is sometimes called {{list}} and sometimes {{result}})



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)