You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/05 04:49:43 UTC
[GitHub] [hbase] liuml07 commented on pull request #1647: add IntelliJ project files
liuml07 commented on pull request #1647:
URL: https://github.com/apache/hbase/pull/1647#issuecomment-623854938
@ndimiduk I looked at the doc and found it makes sense to include idea files in CVS. It's very useful if `automatically add to Version Control` works for us.
However, during testing, I found this I tested this `project-jdk-name` in `misc.xml` would be per-developer. For e.g., in my laptop, it is:
```
diff --git a/.idea/misc.xml b/.idea/misc.xml
index 73c342a45e..2e7b92e141 100644
--- a/.idea/misc.xml
+++ b/.idea/misc.xml
@@ -13,5 +13,5 @@
</list>
</option>
</component>
- <component name="ProjectRootManager" version="2" languageLevel="JDK_1_8" default="false" project-jdk-name="OpenJDK 11" project-jdk-type="JavaSDK" />
+ <component name="ProjectRootManager" version="2" languageLevel="JDK_1_8" default="false" project-jdk-name="1.8" project-jdk-type="JavaSDK" />
</project>
\ No newline at end of file
```
Maybe that is because I named my JDK `1.8` locally.
I tested this patch with new clones.
- Importing the whole directory works. I can see a lot of `**/*.iml` files for those modules. I can search symbols.
- Importing the `pom.xml` also works. I can see a lot of `**/*.iml` files for those modules. I can search symbols.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org