You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by jeremysolarz <gi...@git.apache.org> on 2018/02/23 19:33:25 UTC
[GitHub] libcloud pull request #1174: Extending libcloud ex_create_address to allow i...
GitHub user jeremysolarz opened a pull request:
https://github.com/apache/libcloud/pull/1174
Extending libcloud ex_create_address to allow internal ip creation
## Changes Title (replace this with a logical title for your changes)
### Description
As part of a change for [salt issue 45917](https://github.com/saltstack/salt/issues/45917) to extend it's functionality to allow assignment of static internal ip it is need to extend libcloud.
Extended `ex_create_address` to include two additional parameters
- addressType
- subnetwork
As described in the [REST endpoint for addresses](https://cloud.google.com/compute/docs/reference/rest/beta/addresses).
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [x] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeremysolarz/libcloud trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/libcloud/pull/1174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1174
----
commit 84c28353caadc435ec78cd6d67bcf79b5f426941
Author: Jeremy Solarz <js...@...>
Date: 2018-02-23T10:00:45Z
Add parameters to ex_create_address
commit e479efd19847f2e9519d7da12afd02aa3f1e3c9d
Author: Jeremy Solarz <js...@...>
Date: 2018-02-23T10:01:38Z
Restructure region check to fetch empty region
commit d5560aedcad44edb790022841d5f5b57f4827925
Author: Jeremy Solarz <js...@...>
Date: 2018-02-23T10:03:39Z
Add handling of address_type and subnetwork parameters
commit 0de301a226dd2e147cddfc89ffc95b83a272be01
Author: Jeremy Solarz <js...@...>
Date: 2018-02-23T19:05:51Z
Add fixtures for test of internal ip creation
commit d6bbaeb2c5b61ab5683e56cc3ef035b27a914008
Author: Jeremy Solarz <js...@...>
Date: 2018-02-23T19:06:31Z
Add test for internal ip creation for GCP
commit 90711188a5f86c44c9b9730501c7d8835e8fa5b0
Author: Jeremy Solarz <js...@...>
Date: 2018-02-23T19:08:13Z
Remove INTERNAL address type test
----
---
[GitHub] libcloud pull request #1174: Extending libcloud ex_create_address to allow i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/libcloud/pull/1174
---