You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 10:38:06 UTC

[GitHub] [arrow-datafusion] thinkharderdev commented on a diff in pull request #4130: Consolidate `ParquetExec` tests in `parquet_exec` integration test

thinkharderdev commented on code in PR #4130:
URL: https://github.com/apache/arrow-datafusion/pull/4130#discussion_r1016445210


##########
datafusion/core/src/physical_plan/file_format/parquet.rs:
##########
@@ -900,6 +900,8 @@ pub async fn plan_to_parquet(
 
 #[cfg(test)]
 mod tests {
+    // See also `parquet_exec` integration test
+
     use super::*;

Review Comment:
   No objection from me. I think we can probably leave the pruning tests as unit tests here and just move the more "integration-y" tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org