You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2020/11/30 23:17:25 UTC
[GitHub] [jena-site] kinow commented on a change in pull request #31: missing isPrincipalAuthenticated
kinow commented on a change in pull request #31:
URL: https://github.com/apache/jena-site/pull/31#discussion_r532965956
##########
File path: source/documentation/permissions/evaluator.md
##########
@@ -184,5 +184,10 @@ See the example jar for another implementation example.
public Principal getPrincipal() {
return principal;
}
+
+ @Override
+ public boolean isPrincipalAuthenticated(Object principal) {
+ return principal != null;
+ }
Review comment:
Looks good to me, except the tabs vs. spaces here. Would you be able to update it to match the rest of the existing code example, please, @ebremer ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org