You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/02/10 10:33:43 UTC

[GitHub] [camel-quarkus] ppalaga opened a new issue #690: Do not expose mutable collections from FHIR BuildItems

ppalaga opened a new issue #690: Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/issues/690
 
 
   BuildItems should not expose mutable collections because they are consumed from concurrent threads. Mutability does not seem to be required here. Making the properties immutable would simplify the reasoning about the code. 
   
   This applies at least to 
   
   * Dstu2PropertiesBuildItem
   * R5PropertiesBuildItem
   * R4PropertiesBuildItem
   * Dstu3PropertiesBuildItem

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga closed issue #690: Do not expose mutable collections from FHIR BuildItems

Posted by GitBox <gi...@apache.org>.
ppalaga closed issue #690: Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/issues/690
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] johnpoth commented on issue #690: Do not expose mutable collections from FHIR BuildItems

Posted by GitBox <gi...@apache.org>.
johnpoth commented on issue #690: Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/issues/690#issuecomment-590761495
 
 
   @ppalaga 
   
   The idea here is to allow the user to add FHIR resources to the FHIR context before recording. Otherwise you'll get a ClassNotFoundException. See https://wiki.hl7.org/FHIR_Custom_Resources

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [camel-quarkus] ppalaga commented on issue #690: Do not expose mutable collections from FHIR BuildItems

Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #690: Do not expose mutable collections from FHIR BuildItems
URL: https://github.com/apache/camel-quarkus/issues/690#issuecomment-606720121
 
 
   Fixed via 623e0456c074b26d1ca53cd2baf28b17c23257b3

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services