You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/02/22 15:22:49 UTC
[GitHub] [thrift] Jimexist opened a new pull request #2531: java gen to use private_members instead of private-members as a consistent param casing
Jimexist opened a new pull request #2531:
URL: https://github.com/apache/thrift/pull/2531
<!-- Explain the changes in the pull request below: -->
java gen to use private_members instead of private-members as a consistent param casing
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2531: THRIFT-5526: java gen to use private_members instead of private-members as a consistent param casing
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2531:
URL: https://github.com/apache/thrift/pull/2531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2531: THRIFT-5526: java gen to use private_members instead of private-members as a consistent param casing
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2531:
URL: https://github.com/apache/thrift/pull/2531#issuecomment-1048233076
You are being aware that you are about to introduce a breaking change? Proposal: Accept both forms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2531: THRIFT-5526: java gen to use private_members instead of private-members as a consistent param casing
Posted by GitBox <gi...@apache.org>.
Jimexist commented on pull request #2531:
URL: https://github.com/apache/thrift/pull/2531#issuecomment-1048324974
> Proposal: Accept both forms.
Hi @Jens-G thanks for the suggestion. in fact it's not a breaking change, as in https://github.com/apache/thrift/pull/2531/files#diff-c59dffe78e4250a1f0450c496300e137aa1631b60488108e237a292a1c2e6789R81-R82 both forms are indeed accepted. however do you think i should include this information in the document (`-help` print out) instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org