You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/08/23 06:52:29 UTC

[GitHub] [buildstream] gtristan commented on pull request #1706: simplify jobs

gtristan commented on PR #1706:
URL: https://github.com/apache/buildstream/pull/1706#issuecomment-1223629813

   Long time no reply here sorry.
   
   > Would you be open to reworking this patch such that the element passed to the job can be None (and even have None default value), and document how to make a Job without an Element?
   
   I'd really rather keep all the boiler plate in place which clearly separates the `ElementJob` as a specialized concrete class of the abstract `Job` class.
   
   I know that the `Job` class has some unfortunate knowledge about elements, which is mostly related to logging context, but still it would be great to keep these separate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org