You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "pgaref (via GitHub)" <gi...@apache.org> on 2023/09/09 20:57:23 UTC
[GitHub] [flink] pgaref opened a new pull request, #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
pgaref opened a new pull request, #23386:
URL: https://github.com/apache/flink/pull/23386
https://issues.apache.org/jira/browse/FLINK-33022
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23386:
URL: https://github.com/apache/flink/pull/23386#issuecomment-1712611870
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ed7322d8863e462f5189d1c28194b64f8574fb18",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ed7322d8863e462f5189d1c28194b64f8574fb18",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ed7322d8863e462f5189d1c28194b64f8574fb18 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #23386:
URL: https://github.com/apache/flink/pull/23386#issuecomment-1719696702
> Sorry, I didn't express myself clearly earlier. Please take a look again
Got it! Thanks again @huwh -- updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #23386:
URL: https://github.com/apache/flink/pull/23386#issuecomment-1712609517
@wangzzu @zentol can you please take a look when you have a sec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh merged pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh merged PR #23386:
URL: https://github.com/apache/flink/pull/23386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #23386:
URL: https://github.com/apache/flink/pull/23386#discussion_r1323944084
##########
flink-runtime/src/test/java/org/apache/flink/runtime/failure/FailureEnricherUtilsTest.java:
##########
@@ -109,6 +109,15 @@ public void testGetFailureEnrichers() {
assertThat(enrichers).hasSize(1);
// verify that the failure enricher was created and returned
assertThat(enrichers.iterator().next()).isInstanceOf(TestEnricher.class);
+
+ // Valid plus Invalid Name combination
+ configuration.set(
+ JobManagerOptions.FAILURE_ENRICHERS_LIST,
+ FailureEnricherUtilsTest.class.getName() + "," + TestEnricher.class.getName());
+ final Collection<FailureEnricher> validInvalidEnrichers =
+ FailureEnricherUtils.getFailureEnrichers(configuration, createPluginManager());
+ assertThat(validInvalidEnrichers).hasSize(1);
+ assertThat(enrichers.iterator().next()).isInstanceOf(TestEnricher.class);
Review Comment:
It's appreciated if you could update line 109~111.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/failure/FailureEnricherUtilsTest.java:
##########
@@ -109,6 +109,15 @@ public void testGetFailureEnrichers() {
assertThat(enrichers).hasSize(1);
// verify that the failure enricher was created and returned
assertThat(enrichers.iterator().next()).isInstanceOf(TestEnricher.class);
+
+ // Valid plus Invalid Name combination
+ configuration.set(
+ JobManagerOptions.FAILURE_ENRICHERS_LIST,
+ FailureEnricherUtilsTest.class.getName() + "," + TestEnricher.class.getName());
+ final Collection<FailureEnricher> validInvalidEnrichers =
+ FailureEnricherUtils.getFailureEnrichers(configuration, createPluginManager());
+ assertThat(validInvalidEnrichers).hasSize(1);
+ assertThat(enrichers.iterator().next()).isInstanceOf(TestEnricher.class);
Review Comment:
It is recommended to verify this way to make it clearer.
```suggestion
assertThat(validInvalidEnrichers)
.satisfiesExactly(
enricher -> assertThat(enricher).isInstanceOf(TestEnricher.class));
```
##########
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java:
##########
@@ -105,6 +105,16 @@ static Collection<FailureEnricher> getFailureEnrichers(
includedEnrichers);
}
}
+ includedEnrichers.removeAll(
Review Comment:
We could remove the found enricher after line 91.
And shall we change the name of `includedEnrichers` to `enrichersToLoad`. From the perspective of naming, the `includedEnrichers` is meaning the enrichers that user configured, and it shouldn't be modified. But the `enrichersToLoad` means the enrichers that should be load, when some of it is loaded, it could be removed from this set since it's not need load any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #23386:
URL: https://github.com/apache/flink/pull/23386#discussion_r1325558462
##########
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java:
##########
@@ -87,24 +87,25 @@ static Collection<FailureEnricher> getFailureEnrichers(
final FailureEnricherFactory failureEnricherFactory = factoryIterator.next();
final FailureEnricher failureEnricher =
failureEnricherFactory.createFailureEnricher(configuration);
- if (includedEnrichers.contains(failureEnricher.getClass().getName())) {
+ if (enrichersToLoad.contains(failureEnricher.getClass().getName())) {
failureEnrichers.add(failureEnricher);
- LOG.info(
Review Comment:
We need keep this log here.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java:
##########
@@ -87,24 +87,25 @@ static Collection<FailureEnricher> getFailureEnrichers(
final FailureEnricherFactory failureEnricherFactory = factoryIterator.next();
final FailureEnricher failureEnricher =
failureEnricherFactory.createFailureEnricher(configuration);
- if (includedEnrichers.contains(failureEnricher.getClass().getName())) {
+ if (enrichersToLoad.contains(failureEnricher.getClass().getName())) {
Review Comment:
```suggestion
if (enrichersToLoad.remove(failureEnricher.getClass().getName())) {
```
##########
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java:
##########
@@ -87,24 +87,25 @@ static Collection<FailureEnricher> getFailureEnrichers(
final FailureEnricherFactory failureEnricherFactory = factoryIterator.next();
final FailureEnricher failureEnricher =
failureEnricherFactory.createFailureEnricher(configuration);
- if (includedEnrichers.contains(failureEnricher.getClass().getName())) {
+ if (enrichersToLoad.contains(failureEnricher.getClass().getName())) {
failureEnrichers.add(failureEnricher);
- LOG.info(
- "Found failure enricher {} at {}.",
- failureEnricherFactory.getClass().getName(),
- failureEnricher
- .getClass()
- .getProtectionDomain()
- .getCodeSource()
- .getLocation()
- .getPath());
} else {
LOG.debug(
"Excluding failure enricher {}, not configured in enricher list ({}).",
failureEnricherFactory.getClass().getName(),
- includedEnrichers);
+ enrichersToLoad);
}
}
+ enrichersToLoad.removeAll(
Review Comment:
This removeAll could be removed since we could remove it at line 90.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on a diff in pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on code in PR #23386:
URL: https://github.com/apache/flink/pull/23386#discussion_r1321976643
##########
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java:
##########
@@ -106,23 +108,34 @@ static Collection<FailureEnricher> getFailureEnrichers(
}
}
+ if (!includedEnrichers.values().stream().allMatch(Boolean::booleanValue)) {
Review Comment:
I agree, I went back and forth between changing the method signature but this simplifies things a lot.
Updated, and thanks ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #23386:
URL: https://github.com/apache/flink/pull/23386#issuecomment-1714455145
> @pgaref Thanks for the quick fix, I've left some comments here
Updated! Thanks for the review @wangzzu !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangzzu commented on a diff in pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "wangzzu (via GitHub)" <gi...@apache.org>.
wangzzu commented on code in PR #23386:
URL: https://github.com/apache/flink/pull/23386#discussion_r1320928205
##########
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java:
##########
@@ -106,23 +108,34 @@ static Collection<FailureEnricher> getFailureEnrichers(
}
}
+ if (!includedEnrichers.values().stream().allMatch(Boolean::booleanValue)) {
Review Comment:
i think here can use `includedEnrichers.removeAll(failureEnrichers)` directly.
It is not necessary to modify the return type of `getIncludedFailureEnrichers`. The boolean in the return type of this `getIncludedFailureEnrichers` method is not easy to explain.
##########
flink-runtime/src/main/java/org/apache/flink/runtime/failure/FailureEnricherUtils.java:
##########
@@ -106,23 +108,34 @@ static Collection<FailureEnricher> getFailureEnrichers(
}
}
+ if (!includedEnrichers.values().stream().allMatch(Boolean::booleanValue)) {
Review Comment:
how do you think?
##########
flink-runtime/src/test/java/org/apache/flink/runtime/failure/FailureEnricherUtilsTest.java:
##########
@@ -109,6 +113,14 @@ public void testGetFailureEnrichers() {
assertThat(enrichers).hasSize(1);
// verify that the failure enricher was created and returned
assertThat(enrichers.iterator().next()).isInstanceOf(TestEnricher.class);
+
+ // Valid plus Invalid Name combination
+ configuration.set(
+ JobManagerOptions.FAILURE_ENRICHERS_LIST,
+ FailureEnricherUtilsTest.class.getName() + "," + TestEnricher.class.getName());
+ final Collection<FailureEnricher> validInvalidEnrichers =
+ FailureEnricherUtils.getFailureEnrichers(configuration, createPluginManager());
Review Comment:
here should check the value is exist directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #23386:
URL: https://github.com/apache/flink/pull/23386#issuecomment-1715980837
@huwh do you mind taking a quick look here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pgaref commented on pull request #23386: [FLINK-33022] Log an error when enrichers defined as part of the configuration can not be found/loaded
Posted by "pgaref (via GitHub)" <gi...@apache.org>.
pgaref commented on PR #23386:
URL: https://github.com/apache/flink/pull/23386#issuecomment-1718622106
> Thanks @pgaref for preparing this PR. I left two comments. Please take a look.
Appreciate the review @huwh ! Updated the PR, please let me know what you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org