You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "markap14 (via GitHub)" <gi...@apache.org> on 2026/01/16 21:50:11 UTC

[PR] NIFI-15481: Updated ConnectorActions to reflect that starting is not … [nifi]

markap14 opened a new pull request, #10782:
URL: https://github.com/apache/nifi/pull/10782

   …allowed when invalid. Also updated ValidationState to ensure that we don't return any ValidationResult with a valid flag of true as a 'validation error'.
   
   <!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
   <!-- contributor license agreements.  See the NOTICE file distributed with -->
   <!-- this work for additional information regarding copyright ownership. -->
   <!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
   <!-- (the "License"); you may not use this file except in compliance with -->
   <!-- the License.  You may obtain a copy of the License at -->
   <!--     http://www.apache.org/licenses/LICENSE-2.0 -->
   <!-- Unless required by applicable law or agreed to in writing, software -->
   <!-- distributed under the License is distributed on an "AS IS" BASIS, -->
   <!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
   <!-- See the License for the specific language governing permissions and -->
   <!-- limitations under the License. -->
   
   # Summary
   
   [NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status
   
   ### Pull Request Formatting
   
   - [ ] Pull Request based on current revision of the `main` branch
   - [ ] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [ ] Build completed using `./mvnw clean install -P contrib-check`
     - [ ] JDK 21
     - [ ] JDK 25
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15481: Updated ConnectorActions to reflect that starting is not … [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman merged PR #10782:
URL: https://github.com/apache/nifi/pull/10782


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15481: Updated ConnectorActions to reflect that starting is not … [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on code in PR #10782:
URL: https://github.com/apache/nifi/pull/10782#discussion_r2708550380


##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/components/validation/ValidationState.java:
##########
@@ -17,17 +17,29 @@
 
 package org.apache.nifi.components.validation;
 
-import java.util.Collection;
-
 import org.apache.nifi.components.ValidationResult;
 
+import java.util.Collection;
+import java.util.Collections;
+
 public class ValidationState {
     private final ValidationStatus status;
     private final Collection<ValidationResult> validationErrors;
 
-    public ValidationState(final ValidationStatus status, final Collection<ValidationResult> validationErrors) {
+    public ValidationState(final ValidationStatus status, final Collection<ValidationResult> validationResults) {
         this.status = status;
-        this.validationErrors = validationErrors;
+        // Ensure that if we are provided any valid results, they are filtered out because we only want to store validation failures.
+        this.validationErrors = removeValidResults(validationResults);

Review Comment:
   With this change, do we still need to filter out valid results in `StandardConnectorNode.createStartAction` and `StandardConnectorNode.verify`?



##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java:
##########
@@ -892,7 +892,7 @@ public final ValidationStatus performValidation() {
     }
 
     protected Collection<ValidationResult> computeValidationErrors(final ValidationContext validationContext) {
-        Throwable failureCause = null;
+        Throwable failureCause;

Review Comment:
   This comment isn't about this line but this is the closest I could comment on it. Above in `performValidation` we have the following line:
   
   `final ValidationStatus status = results.isEmpty() ? ValidationStatus.VALID : ValidationStatus.INVALID;`
   
   I _think_ a Connector with only valid results would be incorrectly marked as `INVALID`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15481: Updated ConnectorActions to reflect that starting is not … [nifi]

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on code in PR #10782:
URL: https://github.com/apache/nifi/pull/10782#discussion_r2713389308


##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java:
##########
@@ -892,7 +892,7 @@ public final ValidationStatus performValidation() {
     }
 
     protected Collection<ValidationResult> computeValidationErrors(final ValidationContext validationContext) {
-        Throwable failureCause = null;
+        Throwable failureCause;

Review Comment:
   Yeah, you're right. The framework doesn't add any valid results but it does include the results returned by Connectors, which may. Updated to filter those out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15481: Updated ConnectorActions to reflect that starting is not … [nifi]

Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on PR #10782:
URL: https://github.com/apache/nifi/pull/10782#issuecomment-3773080188

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-15481: Updated ConnectorActions to reflect that starting is not … [nifi]

Posted by "markap14 (via GitHub)" <gi...@apache.org>.
markap14 commented on code in PR #10782:
URL: https://github.com/apache/nifi/pull/10782#discussion_r2713387767


##########
nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/components/validation/ValidationState.java:
##########
@@ -17,17 +17,29 @@
 
 package org.apache.nifi.components.validation;
 
-import java.util.Collection;
-
 import org.apache.nifi.components.ValidationResult;
 
+import java.util.Collection;
+import java.util.Collections;
+
 public class ValidationState {
     private final ValidationStatus status;
     private final Collection<ValidationResult> validationErrors;
 
-    public ValidationState(final ValidationStatus status, final Collection<ValidationResult> validationErrors) {
+    public ValidationState(final ValidationStatus status, final Collection<ValidationResult> validationResults) {
         this.status = status;
-        this.validationErrors = validationErrors;
+        // Ensure that if we are provided any valid results, they are filtered out because we only want to store validation failures.
+        this.validationErrors = removeValidResults(validationResults);

Review Comment:
   Yeah good catch



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org