You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/16 19:14:37 UTC
[GitHub] [arrow-datafusion] andygrove opened a new issue, #2551: Implement physical plan for OFFSET
andygrove opened a new issue, #2551:
URL: https://github.com/apache/arrow-datafusion/issues/2551
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
PR https://github.com/apache/arrow-datafusion/pull/2521 adds OFFSET to the logical plan. We should implement a physical plan for it.
**Describe the solution you'd like**
Implement OFFSET physical plan.
**Describe alternatives you've considered**
None
**Additional context**
None
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] hi-rustin commented on issue #2551: Implement physical plan for OFFSET
Posted by GitBox <gi...@apache.org>.
hi-rustin commented on issue #2551:
URL: https://github.com/apache/arrow-datafusion/issues/2551#issuecomment-1128880710
Can I take this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] hi-rustin commented on issue #2551: Implement physical plan for OFFSET
Posted by GitBox <gi...@apache.org>.
hi-rustin commented on issue #2551:
URL: https://github.com/apache/arrow-datafusion/issues/2551#issuecomment-1129963166
I am working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] hi-rustin commented on issue #2551: Implement physical plan for OFFSET
Posted by GitBox <gi...@apache.org>.
hi-rustin commented on issue #2551:
URL: https://github.com/apache/arrow-datafusion/issues/2551#issuecomment-1133837755
@andygrove Can you provide some help? I'm not quite sure how I should implement it. I see that some of the instructions in the contribution guide are out of date. I would appreciate if you could provide some guidance or reference examples.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb closed issue #2551: Implement physical plan for OFFSET
Posted by GitBox <gi...@apache.org>.
alamb closed issue #2551: Implement physical plan for OFFSET
URL: https://github.com/apache/arrow-datafusion/issues/2551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #2551: Implement physical plan for OFFSET
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2551:
URL: https://github.com/apache/arrow-datafusion/issues/2551#issuecomment-1135752573
I would try and follow the model for limit physical plan as it will be similar: https://github.com/apache/arrow-datafusion/blob/master/datafusion/core/src/physical_plan/limit.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #2551: Implement physical plan for OFFSET
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #2551:
URL: https://github.com/apache/arrow-datafusion/issues/2551#issuecomment-1135751894
Hi @hi-rustin
There is some more detail here https://github.com/apache/arrow-datafusion/pull/2521#issuecomment-1135736282
Here are some queries and examples that should work
Given this input:
```sql
❯ select * from (values (1), (3), (2), (10), (8)) order by column1;
+---------+
| column1 |
+---------+
| 1 |
| 2 |
| 3 |
| 8 |
| 10 |
+---------+
5 rows in set. Query took 0.010 seconds.
```
Trying to run with an `offset` results in:
```sql
❯ select * from (values (1), (3), (2), (10), (8)) order by column1 limit 1 offset 2;
Internal("Unsupported logical plan: OFFSET")
❯ select * from (values (1), (3), (2), (10), (8)) order by column1 limit 1 offset 3;
Internal("Unsupported logical plan: OFFSET")
❯ select * from (values (1), (3), (2), (10), (8)) order by column1 limit 2 offset 3;
Internal("Unsupported logical plan: OFFSET")
❯
```
The answers should be:
```
-- (3)
❯ select * from (values (1), (3), (2), (10), (8)) order by column1 limit 1 offset 2;
-- (8)
❯ select * from (values (1), (3), (2), (10), (8)) order by column1 limit 1 offset 3;
Internal("Unsupported logical plan: OFFSET")
-- (8) (10)
❯ select * from (values (1), (3), (2), (10), (8)) order by column1 limit 2 offset 3;
Internal("Unsupported logical plan: OFFSET")
```
Does that help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org