You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/05/17 12:45:32 UTC
[GitHub] [ozone] elek opened a new pull request #2253: HDDS-5238. Disable animal-sniffer maven plugin
elek opened a new pull request #2253:
URL: https://github.com/apache/ozone/pull/2253
JIRA: https://issues.apache.org/jira/browse/HDDS-5238
## What changes were proposed in this pull request?
animal-sniffer maven plugin can check the API compatibility of the current code with a specific java version.
It's useful when the build uses a JDK (eg. Java 8) which is different from the target JDK (eg. Java 1.6), as it can compare the used Java API signatures with the used ones.
We inherited the plugin execution from the original parent Hadoop pom.xml, but it's not required as we build with Java 8 (and Java 11, but it's not important here) and our target minimum JDK is Java 8.
In the meantime, it's also removed from Hadoop by https://issues.apache.org/jira/browse/HADOOP-15938, as the same functionality (if required) can be achieved by standard javac parameters (see discussion from the Hadoop Jira).
On the other hand, the animal sniffer is slow. Removing it makes the build significant faster:
With master:
```
mvn clean install -DskipTests -Dskip.npx -DskipShade
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:44 min
[INFO] Finished at: 2021-05-17T12:40:15+02:00
[INFO] ------------------------------------------------------------------------
```
With this patch:
```
mvn clean install -DskipTests -Dskip.npx -DskipShade
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 58.603 s
[INFO] Finished at: 2021-05-17T12:42:05+02:00
[INFO] ------------------------------------------------------------------------
```
It seems to be 46 / 104 -> 44% build time improvement.
## How was this patch tested?
Full CI test (+ local builds)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #2253: HDDS-5238. Disable animal-sniffer maven plugin
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2253:
URL: https://github.com/apache/ozone/pull/2253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #2253: HDDS-5238. Disable animal-sniffer maven plugin
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2253:
URL: https://github.com/apache/ozone/pull/2253#issuecomment-842637956
Thanks @elek for the improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org