You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2023/01/10 06:50:08 UTC
[GitHub] [shardingsphere] TeslaCN opened a new issue, #23466: Duplicate definition of data type in PostgreSQL/openGauss BaseRule.g4
TeslaCN opened a new issue, #23466:
URL: https://github.com/apache/shardingsphere/issues/23466
## Refactor
The `dataType` was custom:
https://github.com/apache/shardingsphere/blob/795d3721d648c1ede9f839273b80ee14d89d6ff9/sql-parser/dialect/postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4#L1464-L1477
The `typeName` was the same as PostgreSQL's grammar:
https://github.com/apache/shardingsphere/blob/795d3721d648c1ede9f839273b80ee14d89d6ff9/sql-parser/dialect/postgresql/src/main/antlr4/imports/postgresql/BaseRule.g4#L1075-L1220
https://github.com/postgres/postgres/blob/d952373a987bad331c0e499463159dd142ced1ef/src/backend/parser/gram.y#L13907-L14363
Maybe we should consider unifying the definition of data type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Duplicate definition of data type in PostgreSQL/openGauss BaseRule.g4 [shardingsphere]
Posted by "terrymanu (via GitHub) via notifications" <no...@shardingsphere.apache.org>.
terrymanu commented on issue #23466:
URL: https://github.com/apache/shardingsphere/issues/23466#issuecomment-6624656712
Hi @TeslaCN, #40463 completes the necessary deduplication by sharing common type-name rules while preserving existing parsing and AST behavior. No further unification is needed for this issue, so we can close #23466.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Duplicate definition of data type in PostgreSQL/openGauss BaseRule.g4 [shardingsphere]
Posted by "terrymanu (via GitHub) via notifications" <no...@shardingsphere.apache.org>.
terrymanu closed issue #23466: Duplicate definition of data type in PostgreSQL/openGauss BaseRule.g4
URL: https://github.com/apache/shardingsphere/issues/23466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org